[VSSL-11995] VESSL_NGINX_ENABLED 추가 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NEM-NE
reviewed
Feb 3, 2025
| @@ -2,6 +2,7 @@ agent: | |||
| accessToken: # required | |||
| clusterName: | |||
| providerType: on-premise # on-premise, aws, gcp, oci, azure | |||
| nginxEnabled: true | |||
There was a problem hiding this comment.
value만 추가하는 것이 아니라 helm chart에 sub-chart로 nginx-ingress-controller를 설치하고 싶어요
+) 지금은 aron-onprem에서 설치하고 있을겁니다.
+) nginx-ingress-controller 추가 설정이 필요한 것으로 알고있습니다. 관련해서 @synthdnb 에게 여쭤보시지요
There was a problem hiding this comment.
thomasgim
commented
Feb 3, 2025
Comment on lines
+401
to
+411
| vessl-nginx: | ||
| enabled: true | ||
| controller: | ||
| ingressClass: | ||
| name: "vessl-nginx" | ||
| service: | ||
| # This will create nodePort service on cluster biding port 80 and 443. | ||
| # Set this to false if cluster already has other ingress controller, such as ingress-nginx | ||
| create: false | ||
| # enableSnippets must be true to run VESSL service in nodeport mode | ||
| enableSnippets: true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.