Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): clean up dependencies #261

Closed
wants to merge 4 commits into from

Conversation

JohanHjelsethStorstad
Copy link
Member

This PR:

  • Upgrades react-pdf
  • removes unused typing dependency
  • upgrades eslint-import-resolver-typescript and eslint-plugin-import

I was not able to upgrade eslint to 9.0.0 as eslint-plugin-import does not support it I think

@theodorklauritzen
Copy link
Member

It seems like the upgrade of react-pdf breaks the ombul page

@JohanHjelsethStorstad
Copy link
Member Author

Hah. I tested it in safari and it worked but on chrome it is broken

@Paulijuz
Copy link
Member

Paulijuz commented Jun 25, 2024

I think the building issue is a problem with Next js. According to this comment a fix is now ready for the next release. In the mean time setting swcMinify: false in next.config.js seems to fix the problem.

@JohanHjelsethStorstad
Copy link
Member Author

I don't think changing the next Is a great idea. Have used too much time on this already, so I will revert react-pdf I think, and just hope it get better in the near future

@JohanHjelsethStorstad
Copy link
Member Author

Or just wait to merge this

@Paulijuz
Copy link
Member

I agree that playing around with the next settings isn't a good idea. We can wait until the next update (which hopefully will fix the issue).

@Paulijuz
Copy link
Member

Paulijuz commented Jun 26, 2024

I'll close this pr until then. The other updates were fixed by dependabot anyway

@Paulijuz Paulijuz closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants