Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop MachineDeployment annotation workaround #142

Closed
mnaser opened this issue Jul 2, 2023 · 0 comments · Fixed by #147
Closed

Drop MachineDeployment annotation workaround #142

mnaser opened this issue Jul 2, 2023 · 0 comments · Fixed by #147
Assignees
@okozachenko1203

Comments

@mnaser
Copy link
Member

mnaser commented Jul 2, 2023

Since we've started rolling out CAPI 1.4, we can probably drop the code that worked around this bug:

kubernetes-sigs/cluster-api#7917

We should probably test locally that the metadata properly propagates though.
okozachenko1203 added a commit that referenced this issue Jul 3, 2023
@okozachenko1203
fix: Drop MachineDeployment annotation workaround #142
76804e4 
fix #142
@okozachenko1203 okozachenko1203 mentioned this issue Jul 3, 2023
Merged
@okozachenko1203 okozachenko1203 self-assigned this Jul 3, 2023
mnaser pushed a commit that referenced this issue Jul 5, 2023
@okozachenko1203 @mnaser
fix: Drop MachineDeployment annotation workaround #142
e3981ed 
fix #142
This was referenced Jul 5, 2023
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Jul 24, 2023
Merged
This was referenced Jul 31, 2023
Merged
Merged
@github-actions github-actions bot mentioned this issue Oct 6, 2023
Merged
@github-actions github-actions bot mentioned this issue Oct 13, 2023
Merged
@github-actions github-actions bot mentioned this issue Nov 6, 2023
Merged
@github-actions github-actions bot mentioned this issue Nov 16, 2023
Merged
This was referenced Dec 5, 2023
Merged
Merged
Closed
This was referenced Dec 15, 2023
Closed
Merged
@github-actions github-actions bot mentioned this issue Jan 4, 2024
Merged
@github-actions github-actions bot mentioned this issue Jan 31, 2024
Merged
This was referenced Mar 8, 2024
Merged
Merged
This was referenced Mar 18, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@okozachenko1203 okozachenko1203

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Drop MachineDeployment annotation workaround vexxhost/magnum-cluster-api
2 participants
@mnaser @okozachenko1203