feat: add port update and delete check #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaser
requested changes
Jun 12, 2024
There was a problem hiding this comment.
My first round of review, I would like you to see if you can possibly add unit tests for these for our different scenarios, that would be really useful.
https://flask.palletsprojects.com/en/3.0.x/testing/
Having said that, the examples are using pytest and we're using something else in OpenStack (escaping me) so we can leverage that framework since we're using Zuul to test.
Also, I think we should add pre-commit for black/flake8/isort and introduce a tox target for that and then add a Zuul job for it, since this project is already using Zuul you should be able to add it.
mnaser
requested changes
Jun 18, 2024
ricolin
force-pushed
the
rlin-add-more-founction
branch
from
e65dca4 to
37d55ab
Compare
ricolin
force-pushed
the
rlin-add-more-founction
branch
from
35725b5 to
2fd308d
Compare
ricolin
force-pushed
the
rlin-add-more-founction
branch
from
2fd308d to
001b82c
Compare
|
recheck |
mnaser
approved these changes
Jun 25, 2024
atmosphere-ci bot
pushed a commit
to vexxhost/atmosphere
that referenced
this pull request
Jul 2, 2024
Depends-On vexxhost/neutron-policy-server#1 Reviewed-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser
pushed a commit
to vexxhost/atmosphere
that referenced
this pull request
Jul 2, 2024
Depends-On vexxhost/neutron-policy-server#1 Reviewed-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser
pushed a commit
to vexxhost/atmosphere
that referenced
this pull request
Jul 2, 2024
Depends-On vexxhost/neutron-policy-server#1 Reviewed-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser
pushed a commit
to vexxhost/atmosphere
that referenced
this pull request
Jul 2, 2024
Depends-On vexxhost/neutron-policy-server#1 Reviewed-by: Mohammed Naser <mnaser@vexxhost.com>
mnaser
pushed a commit
to vexxhost/atmosphere
that referenced
this pull request
Jul 2, 2024
Depends-On vexxhost/neutron-policy-server#1 Reviewed-by: Mohammed Naser <mnaser@vexxhost.com>
ricolin
added a commit
to vexxhost/atmosphere
that referenced
this pull request
Jul 3, 2024
Depends-On vexxhost/neutron-policy-server#1 Reviewed-by: Mohammed Naser <mnaser@vexxhost.com>
atmosphere-ci bot
pushed a commit
to vexxhost/atmosphere
that referenced
this pull request
Jul 3, 2024
Depends-On vexxhost/neutron-policy-server#1 Reviewed-by: Mohammed Naser mnaser@vexxhost.com
atmosphere-ci bot
pushed a commit
to vexxhost/atmosphere
that referenced
this pull request
Jul 4, 2024
Depends-On vexxhost/neutron-policy-server#1 Reviewed-by: Mohammed Naser mnaser@vexxhost.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.