Fix exit status on verify haproxy config #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will check for an exit status on verifying the haproxy.cfg. HAproxy may output warnings as an error, but overall it would be considered a valid text and wouldn't stop HAproxy from running.
|
Sorry for not getting back to this earlier. I'll have a limited connection until the end of the week. I'll go through the PR during the weekend. |
vfarcic
added a commit
that referenced
this pull request
Dec 2, 2017
vfarcic
added a commit
that referenced
this pull request
Dec 2, 2017
* Switched over to using a buffer for stdout,stderr on execute #364 (#367) Instead of using Combinedout, switched to using a pipe for stdout and stderr. It seems like running a command on HAProxy doesn't capture the entire stdout and stderr. This will ensure we get everything and see what is actually going if there is an error. * Fixes #364 * Fixes #364 * Fixed #336 * Fix exit status on verify haproxy config This commit will check for an exit status on verifying the haproxy.cfg. HAproxy may output warnings as an error, but overall it would be considered a valid text and wouldn't stop HAproxy from running. * Removed obsolete test for pr #384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will check for an exit status on verifying the haproxy.cfg. HAproxy may output warnings as an error, but overall it would be considered a valid text and wouldn't stop HAproxy from running.