Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WHATWG URL #17

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Add support for WHATWG URL #17

merged 3 commits into from
Jun 11, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 10, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Fixes: #16

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jun 10, 2021
readme.md Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
test.js Show resolved Hide resolved
@wooorm wooorm merged commit be7687f into vfile:main Jun 11, 2021
@github-actions

This comment has been minimized.

@wooorm wooorm added 💪 phase/solved Post is done 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Jun 11, 2021
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jun 11, 2021
wooorm added a commit that referenced this pull request Jun 11, 2021
Related to GH-17.
@aduh95 aduh95 deleted the whatwg-url-support branch June 11, 2021 07:42
@wooorm
Copy link
Member

wooorm commented Jun 11, 2021

Thanks, released!

aduh95 added a commit to targos/node that referenced this pull request Jun 11, 2021
wooorm added a commit to vfile/vfile that referenced this pull request Aug 15, 2021
This adds support for setting file URLs (WHATWG URL objects that
start with `file:`) as `path`, which will convert them to an actual
file path.
This also allows URL objects in the options and on their own as
an argument.

Related to vfile/to-vfile#17
wooorm added a commit to vfile/vfile that referenced this pull request Aug 15, 2021
This adds support for setting file URLs (WHATWG URL objects that
start with `file:`) as `path`, which will convert them to an actual
file path.
This also allows URL objects in the options and on their own as
an argument.

Related to vfile/to-vfile#17
wooorm added a commit to vfile/vfile that referenced this pull request Aug 19, 2021
Closes GH-63.
Related to: vfile/to-vfile#17.

Reviewed-by: Remco Haszing <remcohaszing@gmail.com>
Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

Add support for WHATWG URLs
5 participants