Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to move fatal to “standard” props #11

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Fix to move fatal to “standard” props #11

merged 2 commits into from
Dec 16, 2021

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Move fatal from custom to to standard properties. This matches the readme.

@remcohaszing
Move fatal to standard properties
8f7de7c 
This matches the readme.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 14, 2021
ChristianMurphy
ChristianMurphy approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @remcohaszing

@wooorm wooorm changed the title Move fatal to standard properties Fix to move fatal to “standard” props Dec 16, 2021
@wooorm wooorm merged commit 667d6f6 into vfile:main Dec 16, 2021
@wooorm wooorm added the 💪 phase/solved Post is done label Dec 16, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Dec 16, 2021
@wooorm
Copy link
Member

wooorm commented Dec 16, 2021

“internals” only right? no need to cut a release I believe, or am I missing something?

@remcohaszing
Copy link
Member Author

This one purely fixes an internal inconsistency. You may want to make a release for #12 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remcohaszing @wooorm @ChristianMurphy