Removed fluid from container to shore up header component overflow. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olivewong Do you think you might be able to review and merge this PR? Is it going to conflict especially much with the autocomplete work you are also doing in the header form? |
… Displays popup if link is not copied.
… Fixed popup rendering so popup is displayed if link is not copied upon button click.
… Fixed popup rendering so popup is displayed if link is not copied upon button click.
…Fixed popup rendering so popup with appropriate content is displayed.
… Fixed popup rendering so popup with appropriate content is displayed when link is not copied
Then it can set up the dev server websockets
This adds a line to the devcontainer global bashrc that checks if the Github Codespaces variables are set, and if so sets Webpack to use the Codespaces prot forward for its live reload websocket. We should maybe use a Dockerfile-based build to drop this line in the global bashrc instead.
Create React App doesn't provide a WDS_ env var to control https://github.com/webpack/webpack-dev-server/blob/540c43852ea33f9cb18820e1cef05d5ddb86cc3e/lib/Server.js#L562-L569 when it makes the config at https://github.com/facebook/create-react-app/blob/20edab4894b301f6b90dad0f90a2f82c52a7ac66/packages/react-scripts/config/webpackDevServer.config.js#L19-L22 So we have to actually put the server into HTTPS mode if we want WSS used for the hot reload server. Luckily, Github's proxy ignores self-signed certs. But we still need to set HOST or the proxy weirdly doesn't work with HTTPS ports. See https://github.com/orgs/community/discussions/28563#discussioncomment-4984423
Add devcontainer config to support Codespaces
…lick when link is not copied.
… file object. AvailableTracks now takes an array of tracks
…d content overflow
Highlighted reads
Improved help documentation
…, go button doesn't work without tracks
…f directory, path or URL pairs
Allow URLs to be inputted as BED files
Blue = forward, red = reverse
Highlight reference paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution out in the wild, taking at stab at fixing Form Fields are weirdly wide now.
In HeaderForm.js: Removed 'fluid=true' from HeaderForm and encapsulated the errorDiv and the code outside of the Form at line 452. This seemed to keep the form fields and errorDiv from spilling to the edge of the viewport. Corrected code formatting after my edits.
SampleData tubemap renderings still in tact (not pictured below).
Screenshots from local dev runs pre, and post: