Add a system for "implied" tracks that are present in a chunk but not exposed by the server #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… find them" This reverts commit 55c2fdd.
adamnovak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem where you could follow a link that links to a pre-extracted chunk and then get errors complaining that the graph wasn't available on the server. It also fixes the problem where editing the tracks would produce the same error, and the problem where, if you de-selected a track file for a pre-generated chunk, you couldn't re-select it.
Now we have a notion of "implied" tracks that come from the chunk or the link, which will display a little
(?)in the file picker to represent that the server doesn't actually know about them. We now know better than to ask for the paths in them.This also has to add a lot of logic for keeping the implied tracks and the selected tracks in sync with each other given the different ways they can be modified. And I'm also adding logic to keep the BED regions and the BED file name in sync, and the path names in sync with the graph.