Better traversal size caps in vg call #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg call-cand-Coptions changed to limit search based on all alleles and not just reference allele. This means these options work much better in practice to preventvg callfrom being lost in giant snarls.--progressoption added tovg callDescription
It's come up a number of times where people try to run
vg callon complex graphs and runs forever. The reason being is that it gets lost trying to find traversals through enormous snarls, and there is not enough signal in the read mappings to narrow the search down to something manageable. The min/max traversal cutoffs-c/-Cwere added to address this, but since they only filtered on reference allele length, they only helped sometimes -- it just takes a giant insertion to get around this. This PR changes these options to take into account alt alleles as well. So if you run-c 50 -c 1000, it will only try to genotype sites where at least one traversal is>=50bp, and it will give up on any site as soon as a single traversal>1000bpis found.