Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove examples and utils from repository #820

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Remove examples and utils from repository #820

merged 3 commits into from
Nov 6, 2023

Conversation

leokondrashov
Copy link
Contributor

Summary

Closes #813. Utils and examples in vHive repo are duplicating ones in vSwarm. In order to simplify maintenance, only one copy should be present (vSwarm one).

Implementation Notes ⚒️

  • Redirect all mentions of examples and utils to vSwarm
  • Remove examples and utils from CI (tests and dependabot)

External Dependencies 🍀

  • N/A

Breaking API Changes ⚠️

  • Removes utils and examples, so all projects using them should be redirected to vSwarm's tools and utils.

@leokondrashov leokondrashov mentioned this pull request Sep 15, 2023
Closed
14 tasks
@ustiugov
Copy link
Member

please update the changelog as well.

@leokondrashov leokondrashov marked this pull request as ready for review September 29, 2023 07:15
ustiugov
ustiugov requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment •
edited by leokondrashov
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • create a release of vSwarm with deployer and invoker binaries to be used in the vHive quickstart guide
  • other minor comments

docs/developers_guide.md Outdated Show resolved Hide resolved
docs/quickstart_guide.md Outdated Show resolved Hide resolved
@ustiugov
Copy link
Member

do we need to move anything to vSwarm? ie does vSwarm has everything that we are removing from vHive?

@leokondrashov
Copy link
Contributor Author

do we need to move anything to vSwarm? ie does vSwarm has everything that we are removing from vHive?

All the code is there

@leokondrashov leokondrashov force-pushed the examples-utils-purge branch 2 times, most recently from 821cb32 to 4c82239 Compare November 1, 2023 04:54
@leokondrashov
Copy link
Contributor Author

@ustiugov ready for review

@leokondrashov
Redirect in docs to invoker in vSwarm
8f18fe1 
Signed-off-by: Leonid Kondrashov <leo.kondrashov@gmail.com>
@leokondrashov
Remove invoker and deployer examples
68fddb9 
Signed-off-by: Leonid Kondrashov <leo.kondrashov@gmail.com>
@leokondrashov
Update docs and changelog to reflect move of utils and examples
64c219c 
Signed-off-by: Leonid Kondrashov <leo.kondrashov@gmail.com>
ustiugov
ustiugov approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@leokondrashov leokondrashov merged commit b0d116c into main Nov 6, 2023
22 checks passed
@leokondrashov leokondrashov deleted the examples-utils-purge branch November 6, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove examples from this repository
2 participants
@leokondrashov @ustiugov