Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quick start guide && remove legacy bash files #834

Merged

Conversation

flyinghorse0510
Copy link
Contributor

@flyinghorse0510 flyinghorse0510 commented Oct 2, 2023

Update quick start guide to use Go version scripts
Remove legacy bash files under scripts

@leokondrashov
Copy link
Contributor

As I understand this PR depends on #835, right? Since scripts are completely removed.

And to add, this PR closes #821.

As for the review, please fix linter's errors.

@leokondrashov leokondrashov linked an issue Oct 3, 2023 that may be closed by this pull request
@flyinghorse0510
Copy link
Contributor Author

As I understand this PR depends on #835, right? Since scripts are completely removed.

And to add, this PR closes #821.

As for the review, please fix linter's errors.

Actually it doesn't depend on #835 because in this PR only some useless bash scripts without dependency issues are removed.
But to remove other bash scripts further, #835 need to be done firstly.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/quickstart_guide.md Outdated Show resolved Hide resolved
docs/quickstart_guide.md Show resolved Hide resolved
docs/quickstart_guide.md Outdated Show resolved Hide resolved
docs/quickstart_guide.md Outdated Show resolved Hide resolved
@flyinghorse0510 flyinghorse0510 changed the title Update quick start guide && remove useless bash files Update quick start guide && remove legacy bash files Oct 3, 2023
@leokondrashov
Copy link
Contributor

There is a broken link in the CHANGELOG.md:82. I propose changing it to the quickstart guide section of creating one node cluster. @ustiugov or should we just remove the link from the file?

@leokondrashov leokondrashov force-pushed the setup_refactor_cleanup branch 3 times, most recently from f16eff6 to fa3cdb9 Compare October 13, 2023 12:33
Signed-off-by: flyinghorse0510 <mhy@flyinghorse.top>
@leokondrashov leokondrashov force-pushed the setup_refactor_cleanup branch from fa3cdb9 to bc993fb Compare October 16, 2023 02:07
@leokondrashov leokondrashov merged commit 20c0e34 into vhive-serverless:main Oct 16, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update quick start guide with new scripts
3 participants