Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing a custom dir to install ksops to #240

Merged
merged 2 commits into from
May 31, 2024
Merged

Allow passing a custom dir to install ksops to #240

merged 2 commits into from
May 31, 2024

Conversation

dbramwell
Copy link
Contributor

Recently tried to install ksops in a CI runner. Found this change useful to allow installing to a directory other than "/usr/local/bin/".

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. kind:enhancement New feature or request labels May 28, 2024
devstein
devstein approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Thank you for contributing!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 31, 2024
@devstein devstein merged commit 2b3838b into viaduct-ai:master May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devstein devstein devstein approved these changes

Assignees
No one assigned
Labels
kind:enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbramwell @devstein