cstc40 #517
Merged
cstc40 #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed debug key definition on keymap, fixed optional layer indicator on alpha flagged keys code, debounce set on 2
|
The two versions (daughterboard, single_pcb) need to have a different Vial UID |
lesshonor
suggested changes
Aug 8, 2023
keyboards/kprepublic/cstc40/daughterboard/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
keyboards/kprepublic/cstc40/daughterboard/keymaps/default/keymap.c
Outdated
Show resolved
Hide resolved
lesshonor
suggested changes
Aug 9, 2023
There was a problem hiding this comment.
Overall, you can remove a ton of duplicated boilerplate by moving shared configurations up one level. When I run qmk info -f json on these two keyboards literally the only differences are the matrix pins:
23,24c23,24
< "cols": ["B15", "B14", "B13", "B10", "B12", "A5", "C4", "A7", "A15", "C10", "C11", "C0"],
< "rows": ["B1", "B0", "C5", "A6"]
---
> "cols": ["C7", "C8", "C9", "A8", "A10", "B10", "A15", "C13", "B6", "B5", "B4", "B3"],
> "rows": ["C12", "C10", "C11", "B0"]You can move these shared parts into cstc40/config.h and cstc40/info.json instead of duplicating it between files. See artemis/paragon for an example of how this works.
lesshonor
approved these changes
Aug 16, 2023
|
This keyboard fails to build |
I just checked again and i can compile both the default and the vial keymap for the two board variations. What can i do? |
lesshonor
suggested changes
Aug 19, 2023
14 tasks
|
Hi, Just for information. We made some modifications to the firmware created by @itsvar8 and tested it with QMK. The pull request was just merged to the QMK project - qmk/qmk_firmware#22154 Regards, |
|
@xyzz do i need more changes to be merged? |
thanks for the mention! |
|
No, it looks like it got missed in the queue, sorry about that. |
|
Ok thanks
Il sab 14 ott 2023, 03:41 xyzz ***@***.***> ha scritto:
… No, it looks like it got missed in the queue, sorry about that.
—
Reply to this email directly, view it on GitHub
<#517 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4TZO7HJLELQ54JT56N273DX7HUVNANCNFSM6AAAAAA3F2BG6M>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
lesshonor
pushed a commit
to lesshonor/vial-qmk
that referenced
this pull request
Oct 26, 2023
* Create LICENSE * Add files via upload * Add daughterboard version files * Debounce set to 0 to avoid missing registration of quick keypresses * Set debounce to 1 * Update from upstream Fixed debug key definition on keymap, fixed optional layer indicator on alpha flagged keys code, debounce set on 2 * Fixed same UID problem and default keymaps definitions * Fixed daughterboard VIAL keymap * Keymap fixes and tri-layer implementation * Structure rework * Fix rules.mk position * keymap fixes to pass lint check
lesshonor
pushed a commit
to lesshonor/vial-qmk
that referenced
this pull request
Oct 26, 2023
* Create LICENSE * Add files via upload * Add daughterboard version files * Debounce set to 0 to avoid missing registration of quick keypresses * Set debounce to 1 * Update from upstream Fixed debug key definition on keymap, fixed optional layer indicator on alpha flagged keys code, debounce set on 2 * Fixed same UID problem and default keymaps definitions * Fixed daughterboard VIAL keymap * Keymap fixes and tri-layer implementation * Structure rework * Fix rules.mk position * keymap fixes to pass lint check
lesshonor
pushed a commit
to lesshonor/vial-qmk
that referenced
this pull request
Nov 1, 2023
* Create LICENSE * Add files via upload * Add daughterboard version files * Debounce set to 0 to avoid missing registration of quick keypresses * Set debounce to 1 * Update from upstream Fixed debug key definition on keymap, fixed optional layer indicator on alpha flagged keys code, debounce set on 2 * Fixed same UID problem and default keymaps definitions * Fixed daughterboard VIAL keymap * Keymap fixes and tri-layer implementation * Structure rework * Fix rules.mk position * keymap fixes to pass lint check
zhol0777
pushed a commit
to zhol0777/vial-qmk
that referenced
this pull request
Nov 20, 2023
* Create LICENSE * Add files via upload * Add daughterboard version files * Debounce set to 0 to avoid missing registration of quick keypresses * Set debounce to 1 * Update from upstream Fixed debug key definition on keymap, fixed optional layer indicator on alpha flagged keys code, debounce set on 2 * Fixed same UID problem and default keymaps definitions * Fixed daughterboard VIAL keymap * Keymap fixes and tri-layer implementation * Structure rework * Fix rules.mk position * keymap fixes to pass lint check
janvladimirmostert
pushed a commit
to janvladimirmostert/vial-qmk-chameleon
that referenced
this pull request
Dec 1, 2023
* Create LICENSE * Add files via upload * Add daughterboard version files * Debounce set to 0 to avoid missing registration of quick keypresses * Set debounce to 1 * Update from upstream Fixed debug key definition on keymap, fixed optional layer indicator on alpha flagged keys code, debounce set on 2 * Fixed same UID problem and default keymaps definitions * Fixed daughterboard VIAL keymap * Keymap fixes and tri-layer implementation * Structure rework * Fix rules.mk position * keymap fixes to pass lint check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyboard was shipped with VIAL but the company refused to publish the source so i manually tracked the signle board pcb.
Reddit user u/inigmatics then found out and tested pins for cols and rows of the doughter board version of the pcb.