Add Vial support to Keebio Sinc keyboard #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesshonor
suggested changes
Oct 26, 2023
Comment on lines
23
to
31
| ), | ||
|
|
||
| [2] = LAYOUT_all( | ||
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, | ||
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, | ||
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, | ||
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, | ||
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, | ||
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______ |
There was a problem hiding this comment.
No need to hardcode filler KC_TRNS layers. Dynamic keymaps will automatically fill in "missing" layers at compile-time up to the maximum set in dynamic_keymap.layer_count. (By default, this is 4.)
Suggested change
| ), | |
| [2] = LAYOUT_all( | |
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, | |
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, | |
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, | |
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, | |
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, | |
| _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______, _______ |
| const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][NUM_DIRECTIONS] = { | ||
| [0] = { ENCODER_CCW_CW(KC_VOLU, KC_VOLD), ENCODER_CCW_CW(KC_PGUP, KC_PGDN) }, | ||
| [1] = { ENCODER_CCW_CW(RGB_MOD, RGB_RMOD), ENCODER_CCW_CW(KC_MNXT, KC_MPRV) }, | ||
| [2] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) }, |
There was a problem hiding this comment.
See previous comment.
Suggested change
| [2] = { ENCODER_CCW_CW(_______, _______), ENCODER_CCW_CW(_______, _______) }, |
|
Thank you for the suggestions. Does this resolve it? Also, I'm sorry for not actually checking to see if it would work on rev1 and rev2. For some reason, I just didn't think of it. Now that I'm considering it more, rev2 and rev1 use a totally different microcontroller, so it would never have worked. |
lesshonor
approved these changes
Oct 26, 2023
zhol0777
pushed a commit
to zhol0777/vial-qmk
that referenced
this pull request
Nov 20, 2023
* Add Vial support to Keebio Sinc keyboard * Move Vial keymap to rev4 specifically * Remove unnecessary layer
janvladimirmostert
pushed a commit
to janvladimirmostert/vial-qmk-chameleon
that referenced
this pull request
Dec 1, 2023
* Add Vial support to Keebio Sinc keyboard * Move Vial keymap to rev4 specifically * Remove unnecessary layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Keebio Sinc keyboard. I only have the Rev 4 and thus can only test on it, but as it is based on the Via keymap that works for all models, I would assume this also works for all.