Add Piantor Vial and EstarDyn clone support #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @l4u, hope you're OK with this. |
lesshonor
suggested changes
Oct 31, 2023
rickyelopez
commented
Nov 1, 2023
rickyelopez
force-pushed
the
user/rl/piantorVial
branch
from
07e1b13 to
4ae9275
Compare
|
cool, thanks for your review @lesshonor, I think I've addressed everything. Would you mind taking another look? |
lesshonor
suggested changes
Nov 1, 2023
Rebased Vial config from [here](beekeeb/vial-qmk-piantor@36c0fa9#diff-50b215a89a3057054d008a63d5be69aee88134514ead8b432ab246662cc8fe53) produced by Beekeeb, and added support for EstarDyn Pico clones which each have a WS2812 LED
rickyelopez
force-pushed
the
user/rl/piantorVial
branch
from
4ae9275 to
66fe2d7
Compare
lesshonor
approved these changes
Nov 1, 2023
|
Is this all good to merge? |
zhol0777
pushed a commit
to zhol0777/vial-qmk
that referenced
this pull request
Nov 20, 2023
* Add piantor * Add Piantor Vial and EstarDyn clone support Rebased Vial config from [here](beekeeb/vial-qmk-piantor@36c0fa9#diff-50b215a89a3057054d008a63d5be69aee88134514ead8b432ab246662cc8fe53) produced by Beekeeb, and added support for EstarDyn Pico clones which each have a WS2812 LED --------- Co-authored-by: Leo Lou <louyuhong@gmail.com>
janvladimirmostert
pushed a commit
to janvladimirmostert/vial-qmk-chameleon
that referenced
this pull request
Dec 1, 2023
* Add piantor * Add Piantor Vial and EstarDyn clone support Rebased Vial config from [here](beekeeb/vial-qmk-piantor@36c0fa9#diff-50b215a89a3057054d008a63d5be69aee88134514ead8b432ab246662cc8fe53) produced by Beekeeb, and added support for EstarDyn Pico clones which each have a WS2812 LED --------- Co-authored-by: Leo Lou <louyuhong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased Vial config from here produced by Beekeeb, and added support for EstarDyn Pico clones which each have a WS2812 LED