added vial config,keymap,rules,json for ymdk/ymd40/v2 #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesshonor
suggested changes
Dec 14, 2024
Comment on lines
+52
to
+55
|
|
||
| layer_state_t layer_state_set_user(layer_state_t state) { | ||
| return update_tri_layer_state(state, _LOWER, _RAISE, _ADJUST); | ||
| } |
There was a problem hiding this comment.
Forced tri-layer can be confusing/frustrating since if someone doesn't want it, it can't be disabled from the GUI. You even have an MO(3) key, and this function will prevent it from working. I'd say just get rid of this.
Suggested change
| layer_state_t layer_state_set_user(layer_state_t state) { | |
| return update_tri_layer_state(state, _LOWER, _RAISE, _ADJUST); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added everything to compile vial firmware for the ymdk ymd40 v2 ortho keyboard