fix(web): ensure the usage of maplibre-gl-js version 4.x.x, remove …

…`_addStylesheetToShadowRoot` (maplibre#409)
viamichelin · Sep 10, 2024 · 4a65602 · 4a65602
1 parent 78f3573
commit 4a65602
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 17 deletions.
diff --git a/example/web/index.html b/example/web/index.html
@@ -14,9 +14,9 @@
   <!-- Favicon -->
   <link rel="shortcut icon" type="image/png" href="/favicon.png"/>
 
-  <!-- Maplibre -->
-  <script src='https://unpkg.com/maplibre-gl@latest/dist/maplibre-gl.js'></script>
-  <link href='https://unpkg.com/maplibre-gl@latest/dist/maplibre-gl.css' rel='stylesheet' />
+  <!-- MapLibre -->
+  <script src='https://unpkg.com/maplibre-gl@^4.3/dist/maplibre-gl.js'></script>
+  <link href='https://unpkg.com/maplibre-gl@^4.3/dist/maplibre-gl.css' rel='stylesheet' />
 
   <title>example</title>
   <link rel="manifest" href="/manifest.json">

diff --git a/maplibre_gl_web/lib/src/maplibre_web_gl_platform.dart b/maplibre_gl_web/lib/src/maplibre_web_gl_platform.dart
@@ -1,9 +1,5 @@
 part of maplibre_gl_web;
 
-//TODO Url taken from the Maptiler tutorial; use official and stable release once available
-final _maplibreGlCssUrl =
-    'https://cdn.maptiler.com/maplibre-gl-js/v1.13.0-rc.4/mapbox-gl.css';
-
 class MaplibreMapController extends MapLibreGlPlatform
     implements MapLibreMapOptionsSink {
   late html.DivElement _mapElement;
@@ -61,7 +57,6 @@ class MaplibreMapController extends MapLibreGlPlatform
 
   @override
   Future<void> initPlatform(int id) async {
-    await _addStylesheetToShadowRoot(_mapElement);
     if (_creationParams.containsKey('initialCameraPosition')) {
       var camera = _creationParams['initialCameraPosition'];
       _dragEnabled = _creationParams['dragEnabled'] ?? true;
@@ -176,15 +171,6 @@ class MaplibreMapController extends MapLibreGlPlatform
     }
   }
 
-  Future<void> _addStylesheetToShadowRoot(html.HtmlElement e) async {
-    final link = html.LinkElement()
-      ..href = _maplibreGlCssUrl
-      ..rel = 'stylesheet';
-    e.append(link);
-
-    await link.onLoad.first;
-  }
-
   @override
   Future<CameraPosition?> updateMapOptions(
       Map<String, dynamic> optionsUpdate) async {