Replace pnpm with npm #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
suggested changes
Apr 6, 2023
| "all": "concurrently -g pnpm:check-* pnpm:build", | ||
| "check-format": "pnpm run _prettier-base --check", | ||
| "check-lint": "eslint \"**/*.@(js|cjs|ts)\"", | ||
| "all": "concurrently -g npm:check-* npm:build", |
There was a problem hiding this comment.
does this require concurrently to be installed?
There was a problem hiding this comment.
Concurrently is spec'd as a development dependency, so it is installed by npm install. I added it as a dev dep here (and in Prime last week) after conferring with @micheal-parks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces pnpm with vanilla npm, and updates build scripts and documentation accordingly.
pnpm publish --recursivehas been replaced with JS-DevTools/npm-publish, tied to a commit that has all deprecation issues resolved. I attached it to a commit rather than a version following GitHub Actions security hardening recommendations