Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-5993 - fallback to non-mdns uri when auth fails #109

Merged

Conversation

stuqdog
Copy link
Member

@stuqdog stuqdog commented Apr 11, 2024

Major changes

When attempting to connect with an mDNS uri fails, we now fallthrough and attempt a standard connection.

Attempts to auth to a robot with an org level API key (or presumably any level other than the robot itself) fail when connecting with mDNS. Previously we would just fail; we've now added explicit fallback logic.

@stuqdog stuqdog requested a review from a team as a code owner April 11, 2024 19:25
Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admittedly have no idea what I read (multiple times) 😂
While I don't really understand the language or the background, it does look like it does what your description set out to do. Thought to comment even if I can't really "approve".

@stuqdog
Copy link
Member Author

stuqdog commented Apr 17, 2024

I admittedly have no idea what I read (multiple times) 😂 While I don't really understand the language or the background, it does look like it does what your description set out to do. Thought to comment even if I can't really "approve".

@purplenicole730 I'd be happy to grab a side room and chat offline for a couple minutes if you'd like me to go over/explain anything!

@stuqdog stuqdog merged commit 3f6a4a7 into viamrobotics:main Apr 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants