Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-7282 Log ICE event timings/stats #119

Merged
merged 3 commits into from
Jun 24, 2024
Merged

RSDK-7282 Log ICE event timings/stats #119

merged 3 commits into from
Jun 24, 2024

Conversation

benjirewis
Copy link
Member

@benjirewis benjirewis commented Jun 20, 2024 •
edited
Loading

RSDK-7282

Adds debug-level logs for:

  • Gathering of local ICE candidates
  • Reception of remote ICE candidates
  • Statistics of caller updates for this connection establishment
    • Number of updates
    • Average duration of update
    • Max duration of update

@benjirewis benjirewis requested a review from a team June 21, 2024 12:39
@benjirewis benjirewis marked this pull request as ready for review June 21, 2024 12:39
@benjirewis benjirewis requested a review from a team as a code owner June 21, 2024 12:39
stuqdog
stuqdog reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good. Just a couple minor things and some uncertainty around the total_duration logic.

src/rpc/dial.rs Outdated Show resolved Hide resolved
src/rpc/dial.rs Show resolved Hide resolved
src/rpc/dial.rs Outdated Show resolved Hide resolved
src/rpc/dial.rs Outdated Show resolved Hide resolved
@benjirewis benjirewis merged commit ff51af1 into viamrobotics:main Jun 24, 2024
4 checks passed
@benjirewis benjirewis deleted the ice-timing-logs branch June 24, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheukt cheukt cheukt approved these changes

@stuqdog stuqdog stuqdog approved these changes

@purplenicole730 purplenicole730 Awaiting requested review from purplenicole730 purplenicole730 is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjirewis @stuqdog @cheukt