add logs when freeing string or rust runtime #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
approved these changes
Oct 19, 2022
penguinland
reviewed
Oct 20, 2022
| @@ -255,5 +256,6 @@ pub extern "C" fn free_rust_runtime(rt_ptr: Option<Box<Ffi>>) -> i32 { | |||
| } | |||
| None => {} | |||
| } | |||
| log::debug!("Freeing rust runtime"); | |||
| 0 | |||
There was a problem hiding this comment.
An off-topic question: Why does this function have a return value? If the argument is None, we return -1, and if it's not, we return 0. and the caller already knew what the argument was before they passed it to us. So, what benefit does the return value provide?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.