RSDK-2407 - Fix gRPC error logging #40
Conversation
src/rpc/client_stream.rs
Outdated
| Err(err) | ||
| } | ||
| if let Some(e) = &err { | ||
| log::error!("received gRPC error: {e}"); |
There was a problem hiding this comment.
I went with error level logging here just to increase visibility and because it is definitely an error. However, this may be overkill since we'll still be getting an error from call? Happy to update to debug level if people think that's preferred.
|
Note to reviewers: build is currently failing due to an upstream issue, being tracked/hopefully resolved here. |
| fn drop(&mut self) { | ||
| log::debug!("Dropping base channel {self:?}"); | ||
| } |
There was a problem hiding this comment.
i'm a little confused by this logic - where do we actually drop the channel object? or is the whole point of this PR that it's happening elsewhere so we should only log here?
There was a problem hiding this comment.
drop() is what's called when something leaves scope. So if this calls that means the base_channel is definitely dropped. The log just provides verification
Major changes:
callfunction, but this avoids confusing errors that imply that any gRPC call error is a rust deserialization problem)close_sync- this function was failing before because of issues creating runtimes within runtimes, which caused noisy and erroneous error messages to log when shutting downWebRTCBaseChannelto show that - despite removing theclose_sync- we are in fact successfully droppingWebRTCBaseChannels when done with them.