Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-3956 buf changes #60

Merged
merged 4 commits into from
Jul 12, 2023
Merged

RSDK-3956 buf changes #60

merged 4 commits into from
Jul 12, 2023

Conversation

jckras
Copy link
Member

@jckras jckras commented Jul 11, 2023

The remote generation alpha features on Buf have been deprecated as of July 10, so we need to migrate to remote plugins.

@jckras jckras requested review from stuqdog and a user July 11, 2023 14:43
@jckras jckras requested a review from a team as a code owner July 11, 2023 14:43
@jckras jckras requested review from benjirewis and removed request for a team July 11, 2023 14:43
@stuqdog
Copy link
Member

stuqdog commented Jul 12, 2023

@npmenard fyi these were the necessary fixes to get protobuf working again.

stuqdog
stuqdog approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks Julie :)

@jckras jckras merged commit ae21629 into viamrobotics:main Jul 12, 2023
@jckras jckras deleted the buf-fix branch July 12, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuqdog stuqdog stuqdog approved these changes

@benjirewis benjirewis Awaiting requested review from benjirewis benjirewis is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jckras @stuqdog