Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-4760 include staticlib in release #76

Merged
merged 2 commits into from
Sep 7, 2023
Merged

RSDK-4760 include staticlib in release #76

merged 2 commits into from
Sep 7, 2023

Conversation

abe-winter
Copy link
Member

@abe-winter abe-winter commented Sep 6, 2023

what changed

  • add staticlib to cargo.toml
  • add .a to gcs upload (previously just .so / .dylib)

why

  • in c++, static dependencies simplify the process of deploying to an arbitrary linux distro or version
  • currently our c++ sdk links to the rust-utils .so file, which means we have to either provide the .so or bundle it. switching to the .a embeds necessary rust-utils logic in libviamsdk.so, and optimizes away the rest

downstream work

  • once this lands and we cut a new release, the c++ sdk will change to consume the .a library

@abe-winter abe-winter requested review from njooma and stuqdog September 6, 2023 18:07
@abe-winter abe-winter requested a review from a team as a code owner September 6, 2023 18:07
@abe-winter abe-winter changed the title include staticlib in release RSDK-4760 include staticlib in release Sep 6, 2023
@abe-winter abe-winter merged commit acbdae0 into main Sep 7, 2023
@abe-winter abe-winter deleted the staticlib branch September 7, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants