[RSDK-5820] WebRTC connection improvement #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmenard
requested review from
stuqdog and
benjirewis
and removed request for
a team
benjirewis
reviewed
Feb 7, 2024
There was a problem hiding this comment.
Generally seems good to me, but @stuqdog will have more context. Just a question.
| // Using an mpsc channel to report unrecoverable errors during Signaling, so we | ||
| // don't have to wait until the timeout expires before giving up on this attempt. | ||
| // The size of the channel is set to 1 since any error (or success) should terminate the function | ||
| let (is_open_s, mut is_open_r) = mpsc::channel(1); |
There was a problem hiding this comment.
If it's an mpsc channel with buffer size 1, why not use an oneshot channel?
There was a problem hiding this comment.
oneshot channels cannot be cloned or reused multiple time (send() takes ownership) We could work around it with Arc and interior mutability but it is a bit less elegant IMO
benjirewis
approved these changes
Feb 7, 2024
stuqdog
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make WebRTC connection failure faster when signaling goes wrong instead of waiting for a timeout on is_open. I have also removed AtomicPollableInterrupt and replace it with tokio::sync::* I think these primitive are a bit more flexible and allow for more cooperation between spawned Future.
Note that it won't attempt to connect again when the connection fails