RSDK-8892: Remove ProtoType #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lia-viam
requested review from
stuqdog,
purplenicole730 and
acmorrow
and removed request for
a team and
purplenicole730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally does the migration for getting rid of ProtoType and AttributeMap in favor of ProtoValue et al.
Sorry in advance this diff is a monster. Generally speaking the changes in header files are just search and replace
const AttributeMap& extraforconst ProtoStruct& extra, any non-trivial stuff is for the most part happening in implementation files.There are a lot of simplifications happening in the unit test code and the examples, which were basically the only places where we are actually constructing and using
AttributeMap. Even fewer actual uses ofProtoType, mostly in the example code.