Add permissions APIs and values #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+93
to
+95
| final request = ListAuthorizationsRequest() | ||
| ..organizationId = organizationId | ||
| ..resourceIds.addAll(resourceIds); |
There was a problem hiding this comment.
Ya SUPER useful in not having to create temporary objects for assignment
Comment on lines
+107
to
+109
| return response.authorizedPermissions.first.permissions | ||
| .map((e) => Permission.values.firstWhere((element) => element.value == e)) | ||
| .toList(); |
There was a problem hiding this comment.
[q] (mainly because I'm unfamiliar with the shape of the API response) - why are we only considering the first authorized permission in the response? (response.authorizedPermissions.first)
There was a problem hiding this comment.
This is a great question! It's because the API actually takes in an array of of permissions to check, and then returns an array of validated permissions.
This method only allows for a single permission check, so we will only get (at most) a single permission response back
maximpertsov
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need permissions in the SDK for proactive checks around auth