improve webrtc connection times & misc improvements #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintpurser
commented
Dec 13, 2023
Comment on lines
+28
to
+32
| <string>1.0.0</string> | ||
| <key>CFBundleSignature</key> | ||
| <string>????</string> | ||
| <key>CFBundleVersion</key> | ||
| <string>$(FLUTTER_BUILD_NUMBER)</string> | ||
| <string>1.0.0</string> |
There was a problem hiding this comment.
With Flutter 3.16 they changed how they label these strings in the apple projects code - we ought to regenerate our project to address this - but for now this is a fine bandaid.
if people copied this code to start there own apps it could eventually cause problems like this.
njooma
reviewed
Dec 13, 2023
njooma
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a bit of misc things going on in this PR - I will try and call them out.
Upgrading flutter_webrtc to latest because: flutter-webrtc/flutter-webrtc#1428
upgrading bonsoir to latest because: Skyost/Bonsoir#57 has been resolved
shorten mDNS scan timeout (this was the main thing lengthening connection times, whoops!).
add try catch for camera stream exception i kept hitting.
add comments for .env setup