Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-2544: Add backlinks to docs #235

Merged
merged 3 commits into from
Jul 12, 2024
Merged

DOCS-2544: Add backlinks to docs #235

merged 3 commits into from
Jul 12, 2024

Conversation

npentrel
Copy link
Contributor

No description provided.

@npentrel npentrel requested a review from a team as a code owner June 20, 2024 21:47
@npentrel npentrel requested review from njooma and lia-viam June 20, 2024 21:47
@@ -16,28 +18,41 @@ abstract class Camera extends Resource {
/// ```
/// var nextImage = await myCamera.image();
/// ```
///
/// For more information, see [Camera component](https://docs.viam.com/components/camera/).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extraneous new line

Future<String> getUserIdByEmail(String email) async {
final request = GetUserIDByEmailRequest()..email = email;
final GetUserIDByEmailResponse response = await _client.getUserIDByEmail(request);
return response.userId;
}

/// Create a new [Organization]
Future<Organization> createOrganization(String name) async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was removed by accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep - sorry

Future<Organization> getOrganization(String organizationId) async {
final getOrganizationRequest = GetOrganizationRequest()..organizationId = organizationId;
final GetOrganizationResponse response = await _client.getOrganization(getOrganizationRequest);
return response.organization;
}

/// Checks for namespace availablity throughout all [Organization]s.
Future<bool> getOrganizationNamespaceAvailability(String publicNamespace) async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this was also removed by accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@npentrel npentrel force-pushed the addlinks branch 4 times, most recently from 9625eb7 to 9c0c5bf Compare July 11, 2024 10:02
@npentrel
Copy link
Contributor Author

@njooma Thanks for the review. I've made the changes and merged in updates.

@npentrel npentrel requested a review from njooma July 11, 2024 10:14
@njooma njooma merged commit e38cce8 into main Jul 12, 2024
4 checks passed
@njooma njooma deleted the addlinks branch July 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants