Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-8684] Try with futures #733

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

njooma
Copy link
Member

@njooma njooma commented Sep 16, 2024

This is an alternate attempt at #730

Opening PR so that it's easier to share

Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the killing message disappeared!

@njooma njooma marked this pull request as ready for review September 17, 2024 16:24
@njooma njooma requested a review from a team as a code owner September 17, 2024 16:24
Copy link
Member

@purplenicole730 purplenicole730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! Teamwork

@njooma njooma merged commit 88cb9e7 into viamrobotics:main Sep 17, 2024
12 checks passed
@njooma njooma deleted the RSDK-8684/logging-hang branch September 17, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants