Fix ice candidate proto to webrtc interface conversion #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
commented
Oct 10, 2024
| @@ -30,6 +30,12 @@ module.exports = { | |||
| '@typescript-eslint/no-explicit-any': 'warn', | |||
| '@typescript-eslint/prefer-promise-reject-errors': 'warn', | |||
| 'unicorn/prefer-add-event-listener': 'warn', | |||
| '@typescript-eslint/strict-boolean-expressions': [ | |||
There was a problem hiding this comment.
Turning this on with the exception of booleans feels very worth it to me. I've written numerous bugs due to how optionals are checked in a truthy/falsey way.
edaniels
commented
Oct 10, 2024
| @@ -365,30 +366,30 @@ const iceCandidateFromProto = (i: ICECandidate) => { | |||
| const candidate: RTCIceCandidateInit = { | |||
| candidate: i.candidate, | |||
| }; | |||
| if (i.sdpMid) { | |||
| if (i.sdpMid !== undefined) { | |||
There was a problem hiding this comment.
This is the fix. We we were excluding the right properties because some of them were falsey
edaniels
commented
Oct 10, 2024
| @@ -242,8 +242,9 @@ export class SignalingExchange { | |||
| try { | |||
| await this.pc.addIceCandidate(cand); | |||
| } catch (error) { | |||
| console.log('error adding ice candidate', error); // eslint-disable-line no-console | |||
There was a problem hiding this comment.
This will report an error if this ever happens again and bubble up to the reason of dial failure instead of undefined.
njooma
approved these changes
Oct 10, 2024
ethanlookpotts
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Did not review code but I did try it in a deployed temp environment and it works! https://github.com/viamrobotics/app/pull/6514
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.