Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

[BUG] normalize_per_cell can lead to not exact reproducible results with mixed data #295

Closed
dweemx opened this issue Jan 27, 2021 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dweemx
Copy link
Contributor

dweemx commented Jan 27, 2021

Describe the bug
Applying the scanpy normalize_per_cell function 2 times on the same expression matrix (containing 10x data and RPK SMART-seq2 data) lead to 2 different but very similar results. This bug has also been described more thoroughly here: scverse/scanpy#1612.

To Reproduce
Steps to reproduce the behavior:

  1. Configure with these options:
nextflow config -profile tenx,harmony,singularity > nextflow.config
  1. Run using this entry point:
nextflow -C nextflow.config run vibsinglecellnf/vsn-pipelines -entry harmony
  1. See error:
    No log error. The problem is that the X slot in the AnnData is not reproducible after the normalization step normalize_per_cell between 2 runs. This leads to minor differences into downstream steps (embeddings, ...)
    image

Expected behavior
Both should equal. Interestingly, this seems to happen for smaller datasets like PBMC 1k, 3k datasets from 10x.
image

Screenshots
If applicable, add screenshots to help explain your problem.

Please complete the following information:

  • OS: CentOS
  • Nextflow Version: 20.11.0-edge.5448
  • vsn-pipelines Version: 0.25.0

Additional context
Add any other context about the problem here.

@dweemx dweemx added the bug Something isn't working label Jan 27, 2021
@dweemx dweemx self-assigned this Jan 27, 2021
@dweemx dweemx changed the title [BUG] normalize_per_cell not reproducible with np.float32 [BUG] normalize_per_cell can lead to not exact reproducible results with mixed data Jan 27, 2021
@dweemx dweemx mentioned this issue Jan 28, 2021
dweemx added a commit that referenced this issue Feb 10, 2021
…e_normalization_step_with_mixed_data

Fixes #295
@dweemx dweemx added this to the 0.26.0 milestone Mar 22, 2021
@cflerin cflerin closed this as completed in 09fefc8 Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant