Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.9.x] Add support for -preview=in #2472

Merged
merged 4 commits into from
Sep 1, 2020
Merged

Conversation

Geod24
Copy link
Contributor

@Geod24 Geod24 commented Aug 31, 2020

Geod24 added 2 commits August 31, 2020 12:26
'in' is meant to means 'const scope' (and will soon becomes much more),
so storing an 'in' parameter goes against this.
This is similar to what was done in vibe-core,
which has a copy of this code.
@Geod24
Copy link
Contributor Author

Geod24 commented Aug 31, 2020

For reference, the PR mentioned are required for -preview=in to work, but without it nothing changes.
Eventcore v0.9.9 and vibe-core v1.10.1 have been released, now it's only a matter of having a new diet-ng release.

@Geod24
Copy link
Contributor Author

Geod24 commented Aug 31, 2020

Although vibe-core v1.10.1 seems to be stuck in dub.pm's purgatory.

s-ludwig and others added 2 commits September 1, 2020 13:14
@Geod24 Geod24 merged commit 7c9d145 into vibe-d:v0.9.x Sep 1, 2020
@Geod24 Geod24 deleted the preview-in branch September 1, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants