github-on-prem - auth_info retrieval from github app #14
Conversation
WalkthroughThe changes primarily focus on enhancing the functionality of the Changes
TipsChat with CodeRabbit Bot (
|
|
CodeRabbit review skipped By default, CodeRabbit only reviews PRs on the default branch. If you wish to have PRs reviewed on additional branches, you can configure that under the repository settings in the UI. |
vibi-dpu/src/github/auth.rs
Outdated
| let pem_data = match fs::read(pem_file_path) { | ||
| Ok(data) => data, | ||
| Err(e) => { | ||
| println!("Error reading pem file: {}", e); | ||
| return None; | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Don't use match for anything except debugging. You should read the result of fs::read(pem_file) in a variable, check if that variable is_err(), print the error and return . if not, the rest of the code follows. This helps in keeping the code clean (separation of logic and error handling). For reference, you can see any function in gitops.rs, like - get_excluded_files
vibi-dpu/src/github/auth.rs
Outdated
| let encoding_key = match EncodingKey::from_rsa_pem(&pem_data) { | ||
| Ok(key) => key, | ||
| Err(e) => { | ||
| println!("Error creating encoding key: {}", e); | ||
| return None; | ||
| }, | ||
| }; | ||
| match encode(&Header::new(Algorithm::RS256), &my_claims, &encoding_key) { | ||
| Ok(token) => Some(token), | ||
| Err(e) => { | ||
| println!("Error encoding JWT: {}", e); | ||
| None | ||
| }, | ||
| } |
vibi-dpu/src/github/auth.rs
Outdated
| let pem_data = fs::read(pem_file_path)?; | ||
| fn generate_jwt(github_app_id: &str) -> Option<String> { | ||
| let pem_file_path = "/app/repoprofiler_private.pem"; | ||
| let pem_data = fs::read(pem_file_path); |
vibi-dpu/src/github/auth.rs
Outdated
| println!("Error reading pem file: {:?}", pem_data_err); | ||
| return None; | ||
| } | ||
| let pem_data_res = pem_data.expect("Error reading pem file"); |
There was a problem hiding this comment.
This will be named pem_data, and then used further along
vibi-dpu/src/github/auth.rs
Outdated
| println!("Error encoding JWT: {:?}", token_err); | ||
| return None; | ||
| }; | ||
| let token_result = token.expect("Error encoding JWT"); |
|
SonarCloud Quality Gate failed.
|
Summary by CodeRabbit
reqwest::Clientacross the application, improving performance and resource usage.These updates aim to improve the software's usability, extend its functionality, and enhance its performance and reliability.