Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tr/fix diff command #16

Merged
merged 18 commits into from
Oct 26, 2023
Merged

Tr/fix diff command #16

merged 18 commits into from
Oct 26, 2023

Conversation

avikalpg
Copy link
Member

@avikalpg avikalpg commented Oct 17, 2023

Please check the action items covered in the PR -

  • Remove test environment files from PR
  • Manual QA

Summary by CodeRabbit

  • New Feature: Introduced repository configuration options to control comment insertion and automatic reviewer assignment. This allows users to customize their review process.
  • New Feature: Enhanced the commit range specification in the get_excluded_files function for more flexibility.
  • Improvement: Updated the git blame command to ignore whitespace changes, providing more accurate line authorship information.
  • New Feature: Added a function to save repository configurations to the database, enabling persistent customization across sessions.
  • Improvement: Updated several core functions to accept and utilize the new repository configuration, enhancing the overall review process.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2023

CodeRabbit review skipped

By default, CodeRabbit only reviews PRs on the default branch. If you wish to have PRs reviewed on additional branches, you can configure that under the repository settings in the UI.

@tapishr tapishr changed the base branch from tr/coverage to main October 25, 2023 03:23
@tapishr
Copy link
Member

tapishr commented Oct 25, 2023

This PR has files from tr/test. Will be merged after removing these files from the PR manually

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 26, 2023

Walkthrough

The changes introduce a new RepoConfig struct and modify several functions to accept this new parameter. The RepoConfig struct is used to control whether to insert a comment and/or auto-assign reviewers. The changes also include modifications to the git commands in the gitops module for more flexible commit range specification and ignoring whitespace changes.

Changes

File Summary
.../core/coverage.rs Added repo_config and auto_assign parameters to process_coverage. Adjusted logic to use repo_config for comment insertion and reviewer assignment.
.../core/review.rs Modified process_review, send_hunkmap, and parse_review to accept and handle repo_config. parse_review now returns a tuple (Review, RepoConfig).
.../db/mod.rs Added repo_config and review modules.
.../db/repo_config.rs Added save_repo_config_to_db function to save RepoConfig to a database.
.../utils/gitops.rs Modified get_excluded_files to use commit range. Added -w flag to git blame in generate_blame to ignore whitespace changes.
.../utils/mod.rs Added lineitem and repo_config modules.
.../utils/repo_config.rs Introduced RepoConfig struct with comment and auto_assign fields. Implemented getters and a default() function.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 5e9befd and 99d105e.
Files selected for processing (1)
  • vibi-dpu/src/utils/gitops.rs (1 hunks)
Files skipped from review due to trivial changes (1)
  • vibi-dpu/src/utils/gitops.rs

@tapishr tapishr merged commit 98cbf40 into main Oct 26, 2023
3 checks passed
@tapishr tapishr deleted the tr/fixDiffCommand branch October 26, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants