Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement git blame whitespace filter #24

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Implement git blame whitespace filter #24

merged 1 commit into from
Oct 26, 2023

Conversation

tapishr
Copy link
Member

@tapishr tapishr commented Oct 26, 2023

Merging into main for PR #12

Summary by CodeRabbit

  • Improvement: Enhanced the accuracy of file modification tracking in our system. Now, minor changes like spaces or tabs won't affect the identification of the actual author of a line in a file. This update makes our tracking more precise and reliable, disregarding irrelevant modifications.

@tapishr tapishr self-assigned this Oct 26, 2023
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 26, 2023

Walkthrough

The change introduced in this pull request enhances the accuracy of the blame information generated for a specific line in a file. This is achieved by adding the -w flag to the command, which ignores whitespace changes when determining the commit responsible for the line.

Changes

File Summary
.../src/utils/gitops.rs The -w flag has been added to a command used to generate blame information for a specific line in a file. This flag improves the accuracy of blame information by ignoring irrelevant whitespace modifications.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 452eda0 and 0fa4424.
Files selected for processing (1)
  • vibi-dpu/src/utils/gitops.rs (1 hunks)
Files skipped from review due to trivial changes (1)
  • vibi-dpu/src/utils/gitops.rs

@tapishr tapishr mentioned this pull request Oct 26, 2023
2 tasks
@tapishr tapishr merged commit 4d1a462 into main Oct 26, 2023
3 checks passed
@tapishr tapishr deleted the whitespace branch October 26, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant