Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Tr/zero deletion filter bugfix #68

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

tapishr
Copy link
Member

@tapishr tapishr commented Nov 1, 2023

Please check the action items covered in the PR -

  • Build is running
  • Eventing is functional and tested
  • Unit or integration tests added and running
  • Manual QA

Tested with new file addition -

statstr = 5     8       devprofiler/Cargo.toml
1       0       devprofiler/dummy_file
1       1       devprofiler/src/scanner.rs

fileopt = Some(([StatItem { filepath: "devprofiler/dummy_file", additions: 1, deletions: 0 }], [StatItem { filepath: "devprofiler/Cargo.toml", additions: 5, deletions: 8 }, StatItem { filepath: "devprofiler/src/scanner.rs", additions: 1, deletions: 1 }]))
diffstr = diff --git a/devprofiler/Cargo.toml b/devprofiler/Cargo.toml
index 8bb580e..009521d 100644
--- a/devprofiler/Cargo.toml
+++ b/devprofiler/Cargo.toml
@@ -4 +3,0 @@ version = "0.1.1"
-edition = "2021"
@@ -13,7 +11,0 @@ categories = ["command-line-utilities"]
-
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
-
-[dependencies]
-git2 = {version = "0.15", default-features = false, features= ["vendored-libgit2"]}
-walkdir = "2"
-inquire = "0.5.2"
@@ -22,0 +15,5 @@ pkg-config = "0.3.26"
+
+
+aa
+aa
+aa
\ No newline at end of file

diffstr = diff --git a/devprofiler/src/scanner.rs b/devprofiler/src/scanner.rs
index 382f346..4471b12 100644
--- a/devprofiler/src/scanner.rs
+++ b/devprofiler/src/scanner.rs
@@ -72 +72 @@ impl RepoScanner {
-}
\ No newline at end of file
+}a
\ No newline at end of file

[process_review_changes] diffmap = {"devprofiler/src/scanner.rs": "diff --git a/devprofiler/src/scanner.rs b/devprofiler/src/scanner.rs\nindex 382f346..4471b12 100644\n--- a/devprofiler/src/scanner.rs\n+++ b/devprofiler/src/scanner.rs\n@@ -72 +72 @@ impl RepoScanner {\n-}\n\\ No newline at end of file\n+}a\n\\ No newline at end of file\n", "devprofiler/Cargo.toml": "diff --git a/devprofiler/Cargo.toml b/devprofiler/Cargo.toml\nindex 8bb580e..009521d 100644\n--- a/devprofiler/Cargo.toml\n+++ b/devprofiler/Cargo.toml\n@@ -4 +3,0 @@ version = \"0.1.1\"\n-edition = \"2021\"\n@@ -13,7 +11,0 @@ categories = [\"command-line-utilities\"]\n-\n-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html\n-\n-[dependencies]\n-git2 = {version = \"0.15\", default-features = false, features= [\"vendored-libgit2\"]}\n-walkdir = \"2\"\n-inquire = \"0.5.2\"\n@@ -22,0 +15,5 @@ pkg-config = \"0.3.26\"\n+\n+\n+aa\n+aa\n+aa\n\\ No newline at end of file\n"}
[process_review_changes] linemap = {"devprofiler/src/scanner.rs": ["72,72"], "devprofiler/Cargo.toml": ["4,4", "13,20"]}
blamestr = e6609cfa (<tapish303@gmail.com> 1672335775 72) }

Copy link
Contributor

coderabbitai bot commented Nov 1, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tapishr tapishr merged commit 2a45545 into tr/test Nov 1, 2023
2 checks passed
@tapishr tapishr deleted the tr/zero_deletion_filter_bugfix branch November 1, 2023 15:56
@tapishr tapishr self-assigned this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant