Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md: replace team-monitor-website with vibinex-server #72

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

avikalpg
Copy link
Member

@avikalpg avikalpg commented Nov 3, 2023

Please check the action items covered in the PR -

  • Build is running
  • Eventing is functional and tested
  • Unit or integration tests added and running
  • Manual QA

Summary by CodeRabbit

  • Documentation
    • Updated instructions for cloning the repository locally.
    • Revised steps for setting up the .env.local file.
    • Changed the URL for the .env.local file.
    • Updated the command to start the server.

Copy link
Contributor

coderabbitai bot commented Nov 3, 2023

Walkthrough

The changes made to the README.md file primarily involve the shift from the "team-monitor-website" repository to the "vibinex-server" repository. This includes changes in the repository to be cloned, the location for pasting the client id and secret, the URL in the .env.local file, and the command to start the server.

Changes

File Summary
README.md The repository to be cloned locally has been updated from "team-monitor-website" to "vibinex-server". The instructions for pasting the client id and secret have been updated to reflect this change. The URL in the .env.local file of "vibinex-server" has been updated to "https://example.ngrok-free.app". The command to start the server has been updated from "npm run dev" for "team-monitor-website" to "npm run dev" for "vibinex-server".

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between db21c1e and b6710df.
Files selected for processing (1)
  • README.md (2 hunks)
Additional comments: 1
README.md (1)
  • 50-53: No changes were made in this hunk. The license information is clear and concise.

Comment on lines 15 to 24
1. Generate public url using ngrok - `ngrok http 3000`. We will run our next server locally on port 3000 in later steps.
2. Paste this in OAuth consumers in callback_url field.
3. Clone [team-monitor-webiste](https://github.com/Alokit-Innovations/team-monitor-website/) locally.
4. Paste the client id and secret in team-monitor-wesite in .env.local in root directory. Also use them in the docker command below.
3. Clone [vibinex-server](https://github.com/Alokit-Innovations/vibinex-server/) locally.
4. Paste the client id and secret in vibinex-server in .env.local in root directory. Also use them in the docker command below.
5. Fire up cloud sql proxy - `./cloud-sql-proxy --port 5432 vibi-test-394606:asia-south1:test-db`
6. Change url in team-monitor-website in .env.local - `NEXTAUTH_URL=https://example.ngrok-free.app`
7. Start team-monitor-website - `npm run dev`
6. Change url in vibinex-server in .env.local - `NEXTAUTH_URL=https://example.ngrok-free.app`
7. Start vibinex-server - `npm run dev`
8. Build vibi-dpu, go to vibi-dpu/vibi-dpu and run - `cargo build`
9. Go up to the root directory of vibi-dpu - `cd ../`
10. **Build the Docker image**: In the root directory of the project, run the following command to build a Docker image with the name "dpu".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions are clear and concise. However, it would be helpful to add a note about the prerequisites, such as having Docker, npm, and ngrok installed, and having a GitHub account with the necessary permissions to clone the repository and create OAuth consumers. Also, it would be beneficial to add a note about the need to replace placeholders with actual values in the .env.local file and Docker build command.

@MuskanPaliwal MuskanPaliwal merged commit ea116c3 into main Nov 4, 2023
3 checks passed
@MuskanPaliwal MuskanPaliwal deleted the avikalpg-readme-fix branch November 4, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants