Broken load-theme-buffer-local #5 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use 'noflet' instead of 'flet' to override the functions 'custom-theme-buffer-local-recalc-face' and 'custom-theme-buffer-local-recalc-variable'. In later versions of emacs, 'flet' is reverting to lexical binding instead of dynamic binding, thus the methods are no longer being hooked downsteam. This introduces a dependency on package 'noflet'. I did not update the autoload to automatically require this package. Without this fix, on certain versions of emacs you will get the following message when trying to run 'load-theme-buffer-local': Symbol's function definition is void: symbol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use 'noflet' instead of 'flet' to override
the functions 'custom-theme-buffer-local-recalc-face' and
'custom-theme-buffer-local-recalc-variable'. In later versions
of emacs, 'flet' is reverting to lexical binding instead of
dynamic binding, thus the methods are no longer being hooked
downsteam.
This introduces a dependency on package 'noflet'. I did not
update the autoload to automatically require this package.
Without this fix, on certain versions of emacs you will get
the following message when trying to run 'load-theme-buffer-local':
Symbol's function definition is void: symbol