Improve NullArgumentTest to cover GetShortestPath methods
#475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
==========================================
+ Coverage 91.43% 91.82% +0.39%
==========================================
Files 245 245
Lines 7949 7954 +5
Branches 1611 1611
==========================================
+ Hits 7268 7304 +36
+ Misses 463 436 -27
+ Partials 218 214 -4
☔ View full report in Codecov by Sentry. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the gap in the
NullArgumentTest, where it does not testGetShortestPathmethods. It does so by changing theFunc<>passed in to return an empty enumerable rather thannull.This PR also adds a null-reference check for the returned value from the
getNeighbors()call.Fixes #195