Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Take to properly be escaped #581

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Update Take to properly be escaped #581

merged 2 commits into from
Nov 22, 2023

Conversation

viceroypenguin
Copy link
Owner

This PR updates Take to be present and disabled in net6.0 rather than missing. This matches the behavior of other library functions, and is done so that libraries compiled against older versions of the library will not encounter a missing method exception when upgrading to a tfm where the SuperLinq method is no longer needed.

Fixes #574

@viceroypenguin viceroypenguin added this to the 5.4.0 milestone Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4f6a0a) 93.03% compared to head (30131f8) 93.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files         255      255           
  Lines        8140     8140           
  Branches     1618     1618           
=======================================
  Hits         7573     7573           
  Misses        358      358           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viceroypenguin viceroypenguin merged commit 2c498f5 into master Nov 22, 2023
4 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Take to properly be escaped
1 participant