Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.2.0 install.php db updates #748

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

RealAngeleno
Copy link

I also added a check for https, but did a direct commit without thinking about it too much.

@RealAngeleno
Copy link
Author

RealAngeleno commented May 17, 2024

For convenience, it was the addition of

//The HTTPS check doesn't work properly when in those arrays, so let's run it here and pass along the result during the actual check.

	if (!empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] !== 'off') {
        $httpsvalue = true;
    }

right after "elseif ($step == 1)"

and

array(
			'category' => 'Misc',
			'name' => 'HTTPS being used',
			'result' => $httpsvalue = true,
			'required' => false,
			'message' => 'You are not currently using https for vichan, or at least for your backend server. If this intentional, add "$config[\'cookies\'][\'secure_login_only\'] = 0;" (or 1 if using a proxy) on a new line under "Additional configuration" on the next page.'
		),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant