Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code style #52

Merged
merged 5 commits into from
Apr 5, 2018
Merged

Code style #52

merged 5 commits into from
Apr 5, 2018

Conversation

bakedChicken
Copy link
Contributor

@bakedChicken bakedChicken commented Apr 4, 2018

Hi!
I've added a linter as gradle dependency.
Ktlint is using Android Kotlin Styleguide from Google, so I hope there won't be any "taste" kind of issues.
I think it should be included in contributing guide for keeping sources consistent.

No logic is added in this PR, just cosmetic changes

@vicpinm vicpinm merged commit 6ad1fde into vicpinm:master Apr 5, 2018
@vicpinm
Copy link
Owner

vicpinm commented Apr 5, 2018

Great idea, thanks you so much!

@bakedChicken
Copy link
Contributor Author

You need to install ktlint, then apply settings to idea (global settings only, project wide configs are currently not supported). Android Studio should start formatting code with lint settings.
If you want to see the actual lint problems, you can run ./gradlew ktlintCheck or install pre-commit hook by ktlint --install-git-pre-commit-hook.

@bakedChicken bakedChicken deleted the code-style branch April 5, 2018 10:49
@vicpinm
Copy link
Owner

vicpinm commented Apr 5, 2018

Thanks you, I'm gonna try it. New version 2.2.0 is available with your lastest changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants