-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Petri net executor example #276
Petri net executor example #276
Conversation
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 100 100
Lines 1419 1419
=======================================
Hits 1399 1399
Misses 20 20 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Yeah, looks cool! Thank you! |
The ci output https://github.com/victimsnino/ReactivePlusPlus/actions/runs/3074503201/jobs/4967539918 and https://github.com/victimsnino/ReactivePlusPlus/actions/runs/3074503201/jobs/4967539973 does not give me a clue what to look at (or I am missing it). Do you see it?
Thomas
… On 17 Sep 2022, at 23:05, Aleksey Loginov ***@***.***> wrote:
Yeah, looks cool! Thank you!
Could you address comments from CI to pass it? Then i would merge it
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
You need to unfold Build with Cmake inside this one error:
|
I was unable to easily reproduce this, clang-14 (which is was I had available) didn't give me this error (with the same flags as in the ci-matrix).. However, I think this edit should fix it. |
BENCHMARK RESULTS (AUTOGENERATED)ci-ubuntu-clangObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-ubuntu-gccObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
trampoline schedulerTable
windowTable
with_latest_fromTable
ci-windowsObservable constructionTable
Observable liftTable
Observable subscribeTable
Observable subscribe #2Table
Observer constructionTable
OnNextTable
Subscriber constructionTable
SubscriptionTable
bufferTable
chains creation testTable
combine_latestTable
concatTable
distinct_until_changedTable
firstTable
foundamental sourcesTable
fromTable
immediate schedulerTable
justTable
lastTable
mapTable
mergeTable
observe_onTable
publish_subject callbacksTable
publish_subject routinesTable
repeatTable
scanTable
single-threaded locksTable
skipTable
switch_on_nextTable
takeTable
take_lastTable
take_untilTable
trampoline schedulerTable
windowTable
with_latest_fromTable
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! |
A very cool! Will check it out.
Thomas
… On 18 Sep 2022, at 09:07, Aleksey Loginov ***@***.***> wrote:
You need to unfold Build with Cmake inside this one
error:
Error: /home/runner/work/ReactivePlusPlus/ReactivePlusPlus/src/examples/petri/petri.cpp:84:26: error: local variable 'marking' will be copied despite being returned by name [-Werror,-Wreturn-std-move]
[363](https://github.com/victimsnino/ReactivePlusPlus/actions/runs/3074503201/jobs/4967539973#step:5:366)
return marking;
[364](https://github.com/victimsnino/ReactivePlusPlus/actions/runs/3074503201/jobs/4967539973#step:5:367)
^~~~~~~
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
As promised, an, imho fun and simplified example of implementing Petri net execution using reactive streams.
Note that it could be a bit fancier by executing the transitions in a different context - that way new transitions would get queued while the active transition is still running. Once RPP has something similar to RxCpp's
observe_on_event_loop
it would also be straightforward to actually execute transitions parallel using Rx-patterns.Let me know if you think this example adds value to your project and if there's something you'd like to see clarified/improved.