Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup #501

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Minor cleanup #501

merged 2 commits into from
Dec 26, 2023

Conversation

victimsnino
Copy link
Owner

No description provided.

Copy link
Contributor

github-actions bot commented Dec 26, 2023

BENCHMARK RESULTS (AUTOGENERATED)

ci-ubuntu-gcc

General

name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 304.69 ns 1.54 ns 1.24 ns 1.25
Subscribe empty callbacks to empty observable via pipe operator 301.80 ns 1.54 ns 1.23 ns 1.25

Sources

name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 707.15 ns 0.62 ns 0.62 ns 1.00
from array of 1 - create + subscribe + current_thread 1032.78 ns 4.63 ns 4.63 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 2271.79 ns 79.52 ns 79.34 ns 1.00
defer from array of 1 - defer + create + subscribe + immediate 737.66 ns 0.31 ns 0.31 ns 1.00
interval - interval + take(3) + subscribe + immediate 2128.44 ns 57.98 ns 58.00 ns 1.00
interval - interval + take(3) + subscribe + current_thread 3062.65 ns 32.10 ns 32.12 ns 1.00

Filtering Operators

name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 1085.33 ns 0.31 ns 0.31 ns 1.00
immediate_just+filter(true)+subscribe 830.88 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 996.13 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 859.49 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+first()+subscribe 1294.75 ns 0.62 ns 0.62 ns 1.00
immediate_just(1,2)+last()+subscribe 929.52 ns 0.31 ns 0.31 ns 1.00
immediate_just+take_last(1)+subscribe 1105.76 ns 18.54 ns 17.91 ns 1.04

Schedulers

name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 277.33 ns 1.54 ns 1.23 ns 1.25
current_thread scheduler create worker + schedule 371.73 ns 5.56 ns 5.56 ns 1.00
current_thread scheduler create worker + schedule + recursive schedule 805.56 ns 64.88 ns 64.23 ns 1.01

Transforming Operators

name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 833.20 ns 0.31 ns 0.31 ns 1.00
immediate_just+scan(10, std::plus)+subscribe 886.44 ns 0.31 ns 0.31 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 2347.01 ns 95.88 ns 95.23 ns 1.01
immediate_just+buffer(2)+subscribe 1531.62 ns 14.21 ns 13.59 ns 1.05
immediate_just+window(2)+subscribe + subscsribe inner 2378.79 ns 708.83 ns 685.18 ns 1.03

Conditional Operators

name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 819.05 ns - - 0.00
immediate_just+take_while(true)+subscribe 821.51 ns 0.31 ns 0.31 ns 1.00

Utility Operators

name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 1980.53 ns 0.31 ns 0.31 ns 1.00

Combining Operators

name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 3401.97 ns 112.60 ns 112.22 ns 1.00
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 3665.82 ns 122.42 ns 107.70 ns 1.14
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 85.21 ns 85.67 ns 0.99
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 3639.63 ns 542.40 ns 476.94 ns 1.14

Subjects

name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 34.48 ns 23.26 ns 23.26 ns 1.00

Scenarios

name rxcpp rpp prev rpp ratio
basic sample 1437.00 ns 14.82 ns 14.82 ns 1.00
basic sample with immediate scheduler 1407.17 ns 5.55 ns 5.55 ns 1.00

Aggregating Operators

name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 911.23 ns 0.31 ns 0.31 ns 1.00

ci-macos

General

name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 982.72 ns 3.03 ns 3.03 ns 1.00
Subscribe empty callbacks to empty observable via pipe operator 984.27 ns 3.03 ns 3.03 ns 1.00

Sources

name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 1931.23 ns 0.23 ns 0.23 ns 1.00
from array of 1 - create + subscribe + current_thread 2456.32 ns 25.66 ns 25.77 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 5465.08 ns 250.77 ns 252.23 ns 0.99
defer from array of 1 - defer + create + subscribe + immediate 1982.31 ns 0.23 ns 0.23 ns 1.00
interval - interval + take(3) + subscribe + immediate 4964.27 ns 114.55 ns 118.39 ns 0.97
interval - interval + take(3) + subscribe + current_thread 6046.11 ns 109.90 ns 110.47 ns 0.99

Filtering Operators

name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 2723.71 ns 0.22 ns 0.23 ns 0.95
immediate_just+filter(true)+subscribe 2107.84 ns 0.23 ns 0.23 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 2738.76 ns 0.23 ns 0.23 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 1993.46 ns 0.45 ns 0.47 ns 0.95
immediate_just(1,2)+first()+subscribe 3198.84 ns 0.23 ns 0.23 ns 1.00
immediate_just(1,2)+last()+subscribe 2405.35 ns 0.23 ns 0.23 ns 1.00
immediate_just+take_last(1)+subscribe 3007.32 ns 67.25 ns 71.60 ns 0.94

Schedulers

name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 866.78 ns 2.58 ns 2.63 ns 0.98
current_thread scheduler create worker + schedule 1206.58 ns 36.18 ns 36.01 ns 1.00
current_thread scheduler create worker + schedule + recursive schedule 1998.69 ns 219.83 ns 220.47 ns 1.00

Transforming Operators

name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 2093.51 ns 0.23 ns 0.23 ns 0.98
immediate_just+scan(10, std::plus)+subscribe 2291.74 ns 0.46 ns 0.47 ns 0.97
immediate_just+flat_map(immediate_just(v*2))+subscribe 5126.31 ns 324.09 ns 332.57 ns 0.97
immediate_just+buffer(2)+subscribe 2388.56 ns 67.00 ns 70.30 ns 0.95
immediate_just+window(2)+subscribe + subscsribe inner 5137.41 ns 1898.24 ns 1890.49 ns 1.00

Conditional Operators

name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 2080.75 ns - - 0.00
immediate_just+take_while(true)+subscribe 2087.00 ns 0.23 ns 0.23 ns 0.98

Utility Operators

name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 4783.24 ns 0.23 ns 0.23 ns 0.98

Combining Operators

name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 7533.11 ns 367.92 ns 368.18 ns 1.00
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 8471.50 ns 378.56 ns 380.51 ns 0.99
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 397.67 ns 398.59 ns 1.00
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 8038.39 ns 1396.03 ns 1401.52 ns 1.00

Subjects

name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 71.43 ns 68.06 ns 71.00 ns 0.96

Scenarios

name rxcpp rpp prev rpp ratio
basic sample 2689.03 ns 105.94 ns 109.86 ns 0.96
basic sample with immediate scheduler 2688.05 ns 14.86 ns 14.83 ns 1.00

Aggregating Operators

name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 2281.94 ns 0.22 ns 0.24 ns 0.95

ci-ubuntu-clang

General

name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 268.91 ns 0.88 ns 0.88 ns 1.00
Subscribe empty callbacks to empty observable via pipe operator 270.40 ns 0.88 ns 0.88 ns 1.00

Sources

name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 566.59 ns 0.31 ns 0.31 ns 1.00
from array of 1 - create + subscribe + current_thread 794.70 ns 5.55 ns 5.55 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 1892.62 ns 72.30 ns 71.55 ns 1.01
defer from array of 1 - defer + create + subscribe + immediate 582.82 ns 0.31 ns 0.31 ns 0.99
interval - interval + take(3) + subscribe + immediate 1522.19 ns 57.03 ns 57.03 ns 1.00
interval - interval + take(3) + subscribe + current_thread 2092.34 ns 30.86 ns 30.88 ns 1.00

Filtering Operators

name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 934.30 ns 0.31 ns 0.31 ns 1.00
immediate_just+filter(true)+subscribe 674.11 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 835.30 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 694.43 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+first()+subscribe 1052.27 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+last()+subscribe 747.17 ns 0.31 ns 0.31 ns 1.00
immediate_just+take_last(1)+subscribe 952.69 ns 0.31 ns 0.31 ns 1.00

Schedulers

name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 189.96 ns 0.88 ns 0.88 ns 1.00
current_thread scheduler create worker + schedule 298.09 ns 5.56 ns 5.56 ns 1.00
current_thread scheduler create worker + schedule + recursive schedule 611.98 ns 57.51 ns 57.78 ns 1.00

Transforming Operators

name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 650.15 ns 0.31 ns 0.31 ns 1.00
immediate_just+scan(10, std::plus)+subscribe 700.80 ns 0.31 ns 0.31 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 1788.16 ns 79.83 ns 78.10 ns 1.02
immediate_just+buffer(2)+subscribe 1368.26 ns 13.58 ns 13.58 ns 1.00
immediate_just+window(2)+subscribe + subscsribe inner 2107.04 ns 582.39 ns 610.79 ns 0.95

Conditional Operators

name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 643.24 ns - - 0.00
immediate_just+take_while(true)+subscribe 649.91 ns 0.31 ns 0.31 ns 1.00

Utility Operators

name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 1534.68 ns 0.31 ns 0.31 ns 1.00

Combining Operators

name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 2470.11 ns 89.17 ns 84.30 ns 1.06
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 2976.21 ns 94.45 ns 94.52 ns 1.00
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 79.62 ns 78.67 ns 1.01
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 2614.91 ns 547.56 ns 546.90 ns 1.00

Subjects

name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 26.24 ns 24.35 ns 24.36 ns 1.00

Scenarios

name rxcpp rpp prev rpp ratio
basic sample 1035.79 ns 13.58 ns 13.57 ns 1.00
basic sample with immediate scheduler 1052.64 ns 6.17 ns 6.17 ns 1.00

Aggregating Operators

name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 736.78 ns 0.31 ns 0.31 ns 1.00

ci-windows

General

name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 570.66 ns 3.09 ns 2.47 ns 1.25
Subscribe empty callbacks to empty observable via pipe operator 586.15 ns 3.09 ns 2.47 ns 1.25

Sources

name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 1175.81 ns 4.93 ns 4.93 ns 1.00
from array of 1 - create + subscribe + current_thread 1438.11 ns 20.36 ns 20.06 ns 1.01
concat_as_source of just(1 immediate) create + subscribe 4748.61 ns 154.28 ns 155.12 ns 0.99
defer from array of 1 - defer + create + subscribe + immediate 1210.13 ns 4.93 ns 4.94 ns 1.00
interval - interval + take(3) + subscribe + immediate 3096.76 ns 131.00 ns 129.72 ns 1.01
interval - interval + take(3) + subscribe + current_thread 3465.00 ns 60.45 ns 59.86 ns 1.01

Filtering Operators

name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 1841.34 ns 12.85 ns 12.87 ns 1.00
immediate_just+filter(true)+subscribe 1339.87 ns 12.32 ns 12.33 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 2033.84 ns 13.02 ns 13.05 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 1374.55 ns 15.93 ns 15.79 ns 1.01
immediate_just(1,2)+first()+subscribe 2389.56 ns 12.98 ns 12.64 ns 1.03
immediate_just(1,2)+last()+subscribe 1488.10 ns 14.12 ns 14.10 ns 1.00
immediate_just+take_last(1)+subscribe 2045.29 ns 58.67 ns 59.20 ns 0.99

Schedulers

name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 490.50 ns 4.94 ns 4.94 ns 1.00
current_thread scheduler create worker + schedule 671.32 ns 16.97 ns 16.05 ns 1.06
current_thread scheduler create worker + schedule + recursive schedule 1087.35 ns 106.12 ns 105.22 ns 1.01

Transforming Operators

name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 1329.46 ns 12.33 ns 12.33 ns 1.00
immediate_just+scan(10, std::plus)+subscribe 1442.31 ns 21.27 ns 21.58 ns 0.99
immediate_just+flat_map(immediate_just(v*2))+subscribe 3562.50 ns 200.70 ns 199.07 ns 1.01
immediate_just+buffer(2)+subscribe 2606.86 ns 62.02 ns 61.86 ns 1.00
immediate_just+window(2)+subscribe + subscsribe inner 4158.91 ns 1099.36 ns 1095.79 ns 1.00

Conditional Operators

name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 1574.41 ns 11.45 ns 11.46 ns 1.00
immediate_just+take_while(true)+subscribe 1334.81 ns 12.33 ns 12.33 ns 1.00

Utility Operators

name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 3191.69 ns 7.71 ns 7.71 ns 1.00

Combining Operators

name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 5254.50 ns 243.41 ns 241.75 ns 1.01
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 6466.27 ns 215.11 ns 216.98 ns 0.99
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 216.91 ns 223.60 ns 0.97
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 6224.00 ns 741.74 ns 741.58 ns 1.00

Subjects

name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 36.12 ns 36.10 ns 36.40 ns 0.99

Scenarios

name rxcpp rpp prev rpp ratio
basic sample 1880.04 ns 60.21 ns 59.59 ns 1.01
basic sample with immediate scheduler 1894.95 ns 35.17 ns 35.17 ns 1.00

Aggregating Operators

name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 1776.55 ns 19.98 ns 19.98 ns 1.00

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dbb088) 95.54% compared to head (e86461d) 95.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2     #501   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files          76       76           
  Lines        1907     1907           
=======================================
  Hits         1822     1822           
  Misses         85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victimsnino victimsnino changed the title Upgrade disposables [experiment] Upgrade disposables Dec 26, 2023
@victimsnino victimsnino changed the title [experiment] Upgrade disposables Minor cleanup Dec 26, 2023
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@victimsnino victimsnino marked this pull request as ready for review December 26, 2023 15:15
@victimsnino victimsnino merged commit 8de8ccf into v2 Dec 26, 2023
28 checks passed
@victimsnino victimsnino deleted the updgrade_disposables branch December 26, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant