Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #584

Merged
merged 1 commit into from
May 23, 2024
Merged

fix typo #584

merged 1 commit into from
May 23, 2024

Conversation

daixtrose
Copy link
Contributor

It's just a typo and I felt uncomfortable with it.

@victimsnino
Copy link
Owner

Hi @daixtrose !
Thanks for PR :)
Curious how you found it :) anyway, good catch!

@github-actions GitHub Actions
Copy link
Contributor

BENCHMARK RESULTS (AUTOGENERATED)

ci-ubuntu-gcc

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 310.91 ns 2.16 ns 2.16 ns 1.00
Subscribe empty callbacks to empty observable via pipe operator 305.14 ns 2.16 ns 2.16 ns 1.00

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 695.59 ns 0.31 ns 0.31 ns 1.00
from array of 1 - create + subscribe + current_thread 1050.35 ns 3.42 ns 3.42 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 2208.56 ns 118.51 ns 116.98 ns 1.01
defer from array of 1 - defer + create + subscribe + immediate 720.58 ns 0.31 ns 0.31 ns 1.00
interval - interval + take(3) + subscribe + immediate 2138.74 ns 59.23 ns 59.19 ns 1.00
interval - interval + take(3) + subscribe + current_thread 3027.22 ns 32.40 ns 32.40 ns 1.00
from array of 1 - create + as_blocking + subscribe + new_thread 30412.58 ns 27876.44 ns 27908.68 ns 1.00
from array of 1000 - create + as_blocking + subscribe + new_thread 41978.37 ns 50763.16 ns 50740.48 ns 1.00

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 1077.87 ns 0.31 ns 0.31 ns 1.00
immediate_just+filter(true)+subscribe 840.94 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 989.88 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 850.08 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+first()+subscribe 1243.33 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+last()+subscribe 911.91 ns 0.31 ns 0.31 ns 1.00
immediate_just+take_last(1)+subscribe 1102.96 ns 17.59 ns 17.59 ns 1.00

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 265.36 ns 2.16 ns 2.16 ns 1.00
current_thread scheduler create worker + schedule 380.29 ns 5.87 ns 5.87 ns 1.00
current_thread scheduler create worker + schedule + recursive schedule 849.17 ns 55.29 ns 55.85 ns 0.99

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 869.93 ns 0.31 ns 0.31 ns 1.00
immediate_just+scan(10, std::plus)+subscribe 915.79 ns 0.31 ns 0.31 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 2289.44 ns 173.16 ns 164.18 ns 1.05
immediate_just+buffer(2)+subscribe 1541.83 ns 13.59 ns 13.89 ns 0.98
immediate_just+window(2)+subscribe + subscsribe inner 2417.57 ns 1086.48 ns 1078.03 ns 1.01

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 815.24 ns - - 0.00
immediate_just+take_while(true)+subscribe 839.62 ns 0.31 ns 0.31 ns 1.00

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 2002.46 ns 0.31 ns 0.31 ns 1.00

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 3412.70 ns 184.89 ns 190.69 ns 0.97
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 3610.14 ns 183.81 ns 178.31 ns 1.03
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 130.80 ns 129.93 ns 1.01
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 3468.24 ns 1000.22 ns 1016.01 ns 0.98
immediate_just(1) + zip(immediate_just(2)) + subscribe 2072.63 ns 209.04 ns 219.48 ns 0.95

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 34.58 ns 16.87 ns 16.85 ns 1.00

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 1345.57 ns 13.89 ns 13.90 ns 1.00
basic sample with immediate scheduler 1355.78 ns 5.55 ns 5.55 ns 1.00

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 934.83 ns 0.31 ns 0.31 ns 1.00

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 1111.09 ns 135.26 ns 130.71 ns 1.03

ci-macos

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 987.88 ns 3.91 ns 5.53 ns 0.71
Subscribe empty callbacks to empty observable via pipe operator 970.82 ns 3.84 ns 5.53 ns 0.69

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 1930.10 ns 0.23 ns 0.34 ns 0.70
from array of 1 - create + subscribe + current_thread 2421.71 ns 32.63 ns 46.84 ns 0.70
concat_as_source of just(1 immediate) create + subscribe 5604.28 ns 334.54 ns 487.80 ns 0.69
defer from array of 1 - defer + create + subscribe + immediate 1979.50 ns 0.24 ns 0.36 ns 0.66
interval - interval + take(3) + subscribe + immediate 4925.68 ns 116.08 ns 191.88 ns 0.60
interval - interval + take(3) + subscribe + current_thread 6046.87 ns 95.80 ns 143.49 ns 0.67
from array of 1 - create + as_blocking + subscribe + new_thread 108286.91 ns 91249.00 ns 145507.12 ns 0.63
from array of 1000 - create + as_blocking + subscribe + new_thread 99945.33 ns 87768.27 ns 128129.38 ns 0.68

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 2826.03 ns 0.23 ns 0.34 ns 0.69
immediate_just+filter(true)+subscribe 2103.74 ns 0.23 ns 0.34 ns 0.70
immediate_just(1,2)+skip(1)+subscribe 2744.86 ns 0.23 ns 0.34 ns 0.70
immediate_just(1,1,2)+distinct_until_changed()+subscribe 2068.72 ns 0.47 ns 0.67 ns 0.69
immediate_just(1,2)+first()+subscribe 3160.10 ns 0.23 ns 0.34 ns 0.69
immediate_just(1,2)+last()+subscribe 2378.92 ns 0.23 ns 0.34 ns 0.69
immediate_just+take_last(1)+subscribe 2998.13 ns 70.12 ns 101.13 ns 0.69

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 849.80 ns 4.05 ns 6.67 ns 0.61
current_thread scheduler create worker + schedule 1188.08 ns 39.93 ns 67.27 ns 0.59
current_thread scheduler create worker + schedule + recursive schedule 1990.55 ns 206.56 ns 769.62 ns 0.27

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 2101.98 ns 0.23 ns 0.34 ns 0.69
immediate_just+scan(10, std::plus)+subscribe 2326.54 ns 0.47 ns 0.67 ns 0.70
immediate_just+flat_map(immediate_just(v*2))+subscribe 5274.83 ns 400.76 ns 580.65 ns 0.69
immediate_just+buffer(2)+subscribe 2482.61 ns 69.98 ns 98.73 ns 0.71
immediate_just+window(2)+subscribe + subscsribe inner 5389.62 ns 2287.02 ns 3306.06 ns 0.69

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 2088.69 ns - - 0.00
immediate_just+take_while(true)+subscribe 2105.27 ns 0.23 ns 0.34 ns 0.69

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 4896.02 ns 0.23 ns 0.34 ns 0.70

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 7344.81 ns 439.85 ns 2320.98 ns 0.19
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 8339.14 ns 443.91 ns 884.77 ns 0.50
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 463.75 ns 666.61 ns 0.70
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 7863.67 ns 1899.12 ns 2755.53 ns 0.69
immediate_just(1) + zip(immediate_just(2)) + subscribe 5109.41 ns 823.54 ns 1202.63 ns 0.68

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 76.53 ns 50.31 ns 70.95 ns 0.71

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 2800.88 ns 71.04 ns 144.65 ns 0.49
basic sample with immediate scheduler 2781.74 ns 15.10 ns 27.06 ns 0.56

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 2364.91 ns 0.23 ns 0.34 ns 0.69

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 6538.05 ns 4087.66 ns 5973.13 ns 0.68

ci-ubuntu-clang

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 268.14 ns 1.54 ns 1.56 ns 0.99
Subscribe empty callbacks to empty observable via pipe operator 269.23 ns 1.54 ns 1.56 ns 0.99

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 559.26 ns 0.42 ns 0.31 ns 1.38
from array of 1 - create + subscribe + current_thread 779.82 ns 4.01 ns 4.02 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 2379.49 ns 135.85 ns 141.37 ns 0.96
defer from array of 1 - defer + create + subscribe + immediate 1371.32 ns 0.31 ns 0.31 ns 1.02
interval - interval + take(3) + subscribe + immediate 2179.38 ns 61.02 ns 58.30 ns 1.05
interval - interval + take(3) + subscribe + current_thread 3104.47 ns 31.17 ns 31.17 ns 1.00
from array of 1 - create + as_blocking + subscribe + new_thread 28017.38 ns 27944.66 ns 28093.97 ns 0.99
from array of 1000 - create + as_blocking + subscribe + new_thread 35711.75 ns 32779.26 ns 34260.24 ns 0.96

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 1160.21 ns 0.31 ns 0.31 ns 1.00
immediate_just+filter(true)+subscribe 848.93 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 1093.85 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 871.59 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+first()+subscribe 1364.99 ns 0.31 ns 0.31 ns 1.00
immediate_just(1,2)+last()+subscribe 993.72 ns 0.31 ns 0.31 ns 1.00
immediate_just+take_last(1)+subscribe 1229.12 ns 0.31 ns 0.31 ns 1.00

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 276.61 ns 1.54 ns 1.57 ns 0.98
current_thread scheduler create worker + schedule 399.45 ns 4.01 ns 4.02 ns 1.00
current_thread scheduler create worker + schedule + recursive schedule 845.62 ns 55.55 ns 57.81 ns 0.96

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 837.81 ns 0.31 ns 0.31 ns 1.00
immediate_just+scan(10, std::plus)+subscribe 953.11 ns 0.62 ns 0.62 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 2238.71 ns 139.35 ns 138.42 ns 1.01
immediate_just+buffer(2)+subscribe 1611.12 ns 13.59 ns 14.19 ns 0.96
immediate_just+window(2)+subscribe + subscsribe inner 2513.63 ns 898.24 ns 894.31 ns 1.00

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 832.52 ns - - 0.00
immediate_just+take_while(true)+subscribe 835.61 ns 0.31 ns 0.31 ns 1.00

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 1966.11 ns 0.31 ns 0.31 ns 1.00

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 3227.35 ns 162.45 ns 160.54 ns 1.01
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 3737.83 ns 148.69 ns 148.33 ns 1.00
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 147.87 ns 142.23 ns 1.04
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 3367.81 ns 856.25 ns 838.80 ns 1.02
immediate_just(1) + zip(immediate_just(2)) + subscribe 2193.06 ns 202.30 ns 201.90 ns 1.00

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 52.41 ns 19.06 ns 18.53 ns 1.03

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 1290.73 ns 11.11 ns 11.11 ns 1.00
basic sample with immediate scheduler 1293.28 ns 6.17 ns 6.17 ns 1.00

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 994.14 ns 0.31 ns 0.31 ns 1.00

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 1071.37 ns 134.77 ns 134.34 ns 1.00

ci-windows

General
name rxcpp rpp prev rpp ratio
Subscribe empty callbacks to empty observable 572.36 ns 4.76 ns 4.73 ns 1.00
Subscribe empty callbacks to empty observable via pipe operator 588.69 ns 4.77 ns 4.77 ns 1.00

Sources
name rxcpp rpp prev rpp ratio
from array of 1 - create + subscribe + immediate 1173.37 ns 5.24 ns 5.24 ns 1.00
from array of 1 - create + subscribe + current_thread 1433.80 ns 15.75 ns 15.74 ns 1.00
concat_as_source of just(1 immediate) create + subscribe 3788.49 ns 185.77 ns 194.38 ns 0.96
defer from array of 1 - defer + create + subscribe + immediate 1198.47 ns 5.55 ns 5.55 ns 1.00
interval - interval + take(3) + subscribe + immediate 2965.48 ns 133.52 ns 133.64 ns 1.00
interval - interval + take(3) + subscribe + current_thread 3787.73 ns 52.63 ns 53.90 ns 0.98
from array of 1 - create + as_blocking + subscribe + new_thread 122344.44 ns 113488.89 ns 113380.00 ns 1.00
from array of 1000 - create + as_blocking + subscribe + new_thread 132044.44 ns 133087.50 ns 136011.11 ns 0.98

Filtering Operators
name rxcpp rpp prev rpp ratio
immediate_just+take(1)+subscribe 1857.07 ns 12.90 ns 12.87 ns 1.00
immediate_just+filter(true)+subscribe 1332.03 ns 11.64 ns 11.65 ns 1.00
immediate_just(1,2)+skip(1)+subscribe 2061.76 ns 13.06 ns 13.09 ns 1.00
immediate_just(1,1,2)+distinct_until_changed()+subscribe 1358.71 ns 15.78 ns 15.83 ns 1.00
immediate_just(1,2)+first()+subscribe 2081.00 ns 12.95 ns 12.95 ns 1.00
immediate_just(1,2)+last()+subscribe 1463.18 ns 14.04 ns 14.04 ns 1.00
immediate_just+take_last(1)+subscribe 2046.59 ns 59.41 ns 59.29 ns 1.00

Schedulers
name rxcpp rpp prev rpp ratio
immediate scheduler create worker + schedule 486.03 ns 6.18 ns 6.17 ns 1.00
current_thread scheduler create worker + schedule 656.74 ns 13.07 ns 13.08 ns 1.00
current_thread scheduler create worker + schedule + recursive schedule 1076.24 ns 105.23 ns 105.55 ns 1.00

Transforming Operators
name rxcpp rpp prev rpp ratio
immediate_just+map(v*2)+subscribe 1321.30 ns 11.33 ns 11.71 ns 0.97
immediate_just+scan(10, std::plus)+subscribe 1442.98 ns 21.59 ns 21.59 ns 1.00
immediate_just+flat_map(immediate_just(v*2))+subscribe 3566.08 ns 228.32 ns 222.85 ns 1.02
immediate_just+buffer(2)+subscribe 2318.49 ns 58.54 ns 57.79 ns 1.01
immediate_just+window(2)+subscribe + subscsribe inner 4076.59 ns 1247.12 ns 1705.07 ns 0.73

Conditional Operators
name rxcpp rpp prev rpp ratio
immediate_just+take_while(false)+subscribe 1323.99 ns 11.41 ns 11.41 ns 1.00
immediate_just+take_while(true)+subscribe 1333.02 ns 11.64 ns 11.63 ns 1.00

Utility Operators
name rxcpp rpp prev rpp ratio
immediate_just(1)+subscribe_on(immediate)+subscribe 3179.44 ns 7.71 ns 7.71 ns 1.00

Combining Operators
name rxcpp rpp prev rpp ratio
immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe 6224.39 ns 234.49 ns 230.69 ns 1.02
immediate_just(1) + merge_with(immediate_just(2)) + subscribe 5851.45 ns 228.03 ns 225.50 ns 1.01
immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe - 227.67 ns 243.22 ns 0.94
immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe 5501.84 ns 950.29 ns 961.92 ns 0.99
immediate_just(1) + zip(immediate_just(2)) + subscribe 3548.28 ns 530.95 ns 554.41 ns 0.96

Subjects
name rxcpp rpp prev rpp ratio
publish_subject with 1 observer - on_next 36.32 ns 28.36 ns 27.44 ns 1.03

Scenarios
name rxcpp rpp prev rpp ratio
basic sample 1877.86 ns 56.94 ns 56.86 ns 1.00
basic sample with immediate scheduler 1882.44 ns 37.97 ns 37.97 ns 1.00

Aggregating Operators
name rxcpp rpp prev rpp ratio
immediate_just+reduce(10, std::plus)+subscribe 1457.61 ns 19.98 ns 20.03 ns 1.00

Error Handling Operators
name rxcpp rpp prev rpp ratio
create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe 1926.88 ns 339.56 ns 349.83 ns 0.97

@codecov Codecov
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (721b469) to head (b7527f1).
Report is 66 commits behind head on v2.

Additional details and impacted files 
@@            Coverage Diff             @@
##               v2     #584      +/-   ##
==========================================
- Coverage   95.53%   95.04%   -0.50%     
==========================================
  Files          80       91      +11     
  Lines        2105     1674     -431     
==========================================
- Hits         2011     1591     -420     
+ Misses         94       83      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@victimsnino victimsnino merged commit 1a6ca5c into victimsnino:v2 May 23, 2024
37 checks passed
@daixtrose
Copy link
Contributor Author

daixtrose commented May 23, 2024 •
edited
Loading

Curious how you found it :) anyway, good catch!

I read through the code to learn something. It's a genetic defect of mine to only spot typos in other people's text but never my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victimsnino victimsnino victimsnino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daixtrose @victimsnino