Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local upload support and improve playlist exception #46

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Add local upload support and improve playlist exception #46

merged 3 commits into from
Oct 30, 2024

Conversation

ashish-spext
Copy link
Contributor

@ashish-spext ashish-spext commented Oct 30, 2024 •
edited
Loading

  • Introduce source_type which can be local_file or url
    • Instead of inferring in the agent it is easy for LLM to just send it
  • Upload YouTube playlist exception catching localized to a single fail instead of stopping for the whole playlist
  • Removed collection_id as optional since we will always need collection_id.

Tested prompts:

@ashish-spext ashish-spext linked an issue Oct 30, 2024 that may be closed by this pull request
Local File Upload Support #43
Closed
1 task
@ashish-spext
Copy link
Contributor Author

ashish-spext commented Oct 30, 2024 •
edited
Loading

TODO: YouTube playlist support in URLs copied directly from browser after clicking view all videos of the playlist.
Here one idea can be to ask user to confirm if they want a single video or the whole playlist.
But parking this for now.

ankit-v2-3
ankit-v2-3 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@ankit-v2-3 ankit-v2-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ashish-spext ashish-spext merged commit 5f9d8d8 into main Oct 30, 2024
@ashish-spext ashish-spext deleted the 43-local-file-upload-support branch October 30, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankit-v2-3 ankit-v2-3 ankit-v2-3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local File Upload Support
2 participants
@ashish-spext @ankit-v2-3