Update rollup to v4

and the plugins
video-dev · Nov 22, 2023 · 8f0190e · 8f0190e
1 parent e680e9a
commit 8f0190e
Show file tree

Hide file tree

Showing 6 changed files with 362 additions and 65 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -87,7 +87,7 @@ jobs:
 
       - name: install
         run: |
-          npx -y npm-ci-please@^1.1.1
+          npm ci
         env:
           CI: true
 
@@ -159,7 +159,7 @@ jobs:
 
       - name: install
         run: |
-          npx -y npm-ci-please@^1.1.1
+          npm ci
         env:
           CI: true
 
@@ -203,7 +203,7 @@ jobs:
 
       - name: install
         run: |
-          npx -y npm-ci-please@^1.1.1
+          npm ci
         env:
           CI: true
 
@@ -314,7 +314,7 @@ jobs:
 
       - name: install
         run: |
-          npx -y npm-ci-please@^1.1.1
+          npm ci
         env:
           CI: true
 
@@ -386,7 +386,7 @@ jobs:
 
       - name: install
         run: |
-          npx -y npm-ci-please@^1.1.1
+          npm ci
         env:
           CI: true
 
@@ -458,7 +458,7 @@ jobs:
 
       - name: install
         run: |
-          npx -y npm-ci-please@^1.1.1
+          npm ci
         env:
           CI: true
 

diff --git a/build-config.js b/build-config.js
@@ -77,6 +77,19 @@ const buildConstants = (type, additional = {}) => ({
   },
 });
 
+const buildOnLog = ({ allowCircularDeps } = {}) => {
+  return (level, log, handler) => {
+    if (allowCircularDeps && log.code === 'CIRCULAR_DEPENDENCY') return;
+
+    if (level === 'warn') {
+      // treat warnings as errors
+      handler('error', log);
+    } else {
+      handler(level, log);
+    }
+  };
+};
+
 const workerFnBanner = '(function __HLS_WORKER_BUNDLE__(__IN_WORKER__){';
 const workerFnFooter = '})(false);';
 
@@ -255,12 +268,7 @@ const buildRollupConfig = ({
 
   return {
     input,
-    onwarn: (e) => {
-      if (allowCircularDeps && e.code === 'CIRCULAR_DEPENDENCY') return;
-
-      // treat warnings as errors
-      throw new Error(e);
-    },
+    onLog: buildOnLog({ allowCircularDeps }),
     output: {
       name: 'Hls',
       file: outputFile
@@ -331,10 +339,7 @@ const configs = Object.entries({
   }),
   worker: {
     input: './src/demux/transmuxer-worker.ts',
-    onwarn: (e) => {
-      // treat warnings as errors
-      throw new Error(e);
-    },
+    onLog: buildOnLog(),
     output: {
       name: 'HlsWorker',
       file: './dist/hls.worker.js',
@@ -355,10 +360,7 @@ const configs = Object.entries({
   },
   demo: {
     input: './demo/main.js',
-    onwarn: (e) => {
-      // treat warnings as errors
-      throw new Error(e);
-    },
+    onLog: buildOnLog(),
     output: {
       name: 'HlsDemo',
       file: './dist/hls-demo.js',