Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m3u8-parser, EXT-X-KEY URI handling #2737

Closed
itsjamie opened this issue May 14, 2020 · 0 comments
Closed

m3u8-parser, EXT-X-KEY URI handling #2737

itsjamie opened this issue May 14, 2020 · 0 comments

Comments

@itsjamie
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Currently, the m3u8-parser for handling EXT-X-KEY doesn't handle keys that aren't URLs.

I believe absolute versus relative URLs are handled via the url-toolkit dependency we are using, but we need to be able to detect when we aren't dealing with a URL path, and instead a URI, so that we can flow down the alternative path of not using the url-toolkit.

Describe the solution you'd like

The TODO noted below needs to be handled so we can work towards manifest signalled DRM in the data model of hls.js.

Additional context

https://github.com/video-dev/hls.js/pull/2735/files#diff-c66c76a43ba1843baa5bdcec54b3bec2R328-R330

@robwalch robwalch added the DRM label Apr 6, 2021
@robwalch robwalch added this to the 1.3.0 milestone Jul 16, 2022
@robwalch robwalch mentioned this issue Sep 28, 2022
3 tasks
robwalch added a commit that referenced this issue Dec 15, 2022
* Add support for com.apple.fps keySystem

* Improve support for DRM key-systems and key handling
Resolves #2833 #2737 #4318 #4538

* Update README `licenseXhrSetup` example

* Update api-extractor markdown

* Attach CDM on start when even when initial fragments do not have a key associated with them

* Handle expired key status correctly

* Map key-sessions by key ID and log key ID more often than URI

* Support "clear-lead" key-session creation without new config

* Emit and handle FRAG_PARSING_ERROR from transmuxers (#5018)

* Emit and handle FRAG_PARSING_ERROR from transmuxers
Related to #5011
* Switch levels on Key and Fragment parsing errors or escalate to fatal error

* Route all key-system errors to `onFragmentOrKeyLoadError`

* Populate EMEKeyError.err for better demo error logging

* Remove `useEmeEncryptedEvent` and mark `widevineLicenseUrl` as deprecated in API.md

* Add support for EXT-X-SESSION-KEY tags (for key-system access on manifest loaded)
#4927

* Throw before licenseXhrSetup if key was removed

* Make key session promise chain more consice

* Stop on fatal key system errors

* Only request access to key-systems for keys matching those found in the config one at time (to avoid gaining access to WV and PR on Edge)

* Modify key-system helpers so that it's easier to support additional key-system strings

* Add undocumented `generateRequest` ("Content ID") filter

Co-authored-by: Vincent Valot <vincent.valot@bedrockstreaming.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants